Promoted getattr() from FunctionDef to Lambda (#1472)

Co-authored-by: Daniël van Noord <[email protected]>

Author: jacobtylerwalls

ChangeLog

@@ -12,6 +12,9 @@ What's New in astroid 2.11.1?
 =============================
 Release date: TBA
 
+* Promoted ``getattr()`` from ``astroid.scoped_nodes.FunctionDef`` to its parent
+  ``astroid.scoped_nodes.Lambda``.
+
 
 
 What's New in astroid 2.11.0?

astroid/nodes/scoped_nodes/scoped_nodes.py

@@ -39,7 +39,7 @@
 from astroid.interpreter.dunder_lookup import lookup
 from astroid.interpreter.objectmodel import ClassModel, FunctionModel, ModuleModel
 from astroid.manager import AstroidManager
-from astroid.nodes import Arguments, Const, node_classes
+from astroid.nodes import Arguments, Const, NodeNG, node_classes
 from astroid.nodes.scoped_nodes.mixin import ComprehensionScope, LocalsDictNodeNG
 from astroid.nodes.scoped_nodes.utils import builtin_lookup
 from astroid.nodes.utils import Position
@@ -1074,6 +1074,8 @@ class Lambda(mixins.FilterStmtsMixin, LocalsDictNodeNG):
     _other_other_fields = ("locals",)
     name = "<lambda>"
     is_lambda = True
+    special_attributes = FunctionModel()
+    """The names of special attributes that this function has."""
 
     def implicit_parameters(self):
         return 0
@@ -1133,6 +1135,8 @@ def __init__(
         :type: list(NodeNG)
         """
 
+        self.instance_attrs: Dict[str, List[NodeNG]] = {}
+
         super().__init__(
             lineno=lineno,
             col_offset=col_offset,
@@ -1263,6 +1267,21 @@ def frame(self: T, *, future: Literal[None, True] = None) -> T:
         """
         return self
 
+    def getattr(
+        self, name: str, context: Optional[InferenceContext] = None
+    ) -> List[NodeNG]:
+        if not name:
+            raise AttributeInferenceError(target=self, attribute=name, context=context)
+
+        found_attrs = []
+        if name in self.instance_attrs:
+            found_attrs = self.instance_attrs[name]
+        if name in self.special_attributes:
+            found_attrs.append(self.special_attributes.lookup(name))
+        if found_attrs:
+            return found_attrs
+        raise AttributeInferenceError(target=self, attribute=name)
+
 
 class FunctionDef(mixins.MultiLineBlockMixin, node_classes.Statement, Lambda):
     """Class representing an :class:`ast.FunctionDef`.
@@ -1281,11 +1300,7 @@ class FunctionDef(mixins.MultiLineBlockMixin, node_classes.Statement, Lambda):
     returns = None
     decorators: Optional[node_classes.Decorators] = None
     """The decorators that are applied to this method or function."""
-    special_attributes = FunctionModel()
-    """The names of special attributes that this function has.
 
-    :type: objectmodel.FunctionModel
-    """
     is_function = True
     """Whether this node indicates a function.
 
@@ -1583,22 +1598,6 @@ def block_range(self, lineno):
         """
         return self.fromlineno, self.tolineno
 
-    def getattr(self, name, context=None):
-        """this method doesn't look in the instance_attrs dictionary since it's
-        done by an Instance proxy at inference time.
-        """
-        if not name:
-            raise AttributeInferenceError(target=self, attribute=name, context=context)
-
-        found_attrs = []
-        if name in self.instance_attrs:
-            found_attrs = self.instance_attrs[name]
-        if name in self.special_attributes:
-            found_attrs.append(self.special_attributes.lookup(name))
-        if found_attrs:
-            return found_attrs
-        raise AttributeInferenceError(target=self, attribute=name)
-
     def igetattr(self, name, context=None):
         """Inferred getattr, which returns an iterator of inferred statements."""
         try:

tests/unittest_inference.py

@@ -4388,7 +4388,8 @@ def test_lambda(self) -> None:
         """
         )
         inferred = next(node.infer())
-        self.assertEqual(inferred, util.Uninferable)
+        self.assertIsInstance(inferred, nodes.Const)
+        self.assertIs(inferred.value, False)
 
 
 class BoolOpTest(unittest.TestCase):

tests/unittest_scoped_nodes.py

@@ -484,6 +484,12 @@ def test_lambda_qname(self) -> None:
         astroid = builder.parse("lmbd = lambda: None", __name__)
         self.assertEqual(f"{__name__}.<lambda>", astroid["lmbd"].parent.value.qname())
 
+    def test_lambda_getattr(self) -> None:
+        astroid = builder.parse("lmbd = lambda: None")
+        self.assertIsInstance(
+            astroid["lmbd"].parent.value.getattr("__code__")[0], nodes.Unknown
+        )
+
     def test_is_method(self) -> None:
         data = """
             class A: