pre-commit pylint hook is a system hook

[jacobtylerwalls]

Using a system hook for pylint expects there to be a global install of pylint. What about using pylint from PyPI?

pylint...................................................................Failed
- hook id: pylint
- exit code: 1

Executable `pylint` not found

[Pierre-Sassoulas]

We'll have to sync "additional dependencies" between the pre-commit configuration and astroid's own dependencies, whereas we don't have to duplicate that that if we use the system install. (Also it will install them in two places, which is going to hurt for numpy/pyqt6 and tensorflow if we ever add tensorflow brains).

[jacobtylerwalls]

Doesn't pre commit use an isolated environment?

[Pierre-Sassoulas]

Yes, but pylint need all the dependencies installed in this isolated environment so we need to add additional_dependencies: [duplicated list of all astroid dependencies taken from pyproject.toml / requirements_test.txt], then we need to keep it in sync and every time we change something we have to reinstall everything in a new isolated venv for pre-commit instead of just installing the new dependencie in the local venv (which we already do). Related to pylint-dev/pylint#5293