Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 2, 2025

Improvements identified by the improve-conditionals check from pylint-dev/pylint#10600.
After the pylint v4 release, the check should be added to MESSAGE CONTROL.enable.

enable=useless-suppression

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Oct 2, 2025
@cdce8p cdce8p force-pushed the improve-conditionals branch from a038a04 to 5d82c4b Compare October 2, 2025 11:52
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (61aa567) to head (5d82c4b).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          92       92           
  Lines       11148    11148           
=======================================
  Hits        10409    10409           
  Misses        739      739           
Flag Coverage Δ
linux 93.23% <100.00%> (ø)
pypy 93.37% <100.00%> (ø)
windows 93.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_builtin_inference.py 92.03% <100.00%> (ø)
astroid/brain/brain_dataclasses.py 93.85% <100.00%> (ø)
astroid/brain/brain_type.py 100.00% <100.00%> (ø)
astroid/brain/brain_typing.py 88.81% <100.00%> (ø)
astroid/helpers.py 95.33% <100.00%> (ø)
astroid/nodes/scoped_nodes/scoped_nodes.py 93.58% <100.00%> (ø)
astroid/protocols.py 90.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

except InferenceError:
return util.Uninferable
if len(types) > 1 or not types:
if len(types) != 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@cdce8p cdce8p merged commit 0562ce3 into pylint-dev:main Oct 2, 2025
19 checks passed
@cdce8p cdce8p deleted the improve-conditionals branch October 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants