Skip to content

Commit 55ca488

Browse files
committed
Need some backwards compat in urls test depending on which version of django is installed
1 parent bb3cb1e commit 55ca488

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
fail-fast: false
4040
matrix:
4141
python-version: [3.6, 3.7, 3.8, 3.9]
42-
django-version: [-master, 3.2, 3.1, "3.0", "2.0", 1.11]
42+
django-version: [-main, 3.2, 3.1, "3.0", "2.0", 1.11]
4343

4444
steps:
4545
- uses: actions/checkout@v2

pylint_django/tests/input/func_noerror_urls.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
"""
55
# pylint: disable=missing-docstring
66

7-
from django.conf.urls import url
7+
try:
8+
# to be able to test django versions from 1.11 - 3.2
9+
from django.urls import path
10+
except ImportError:
11+
from django.conf.urls import url as path
812
from django.views.generic import TemplateView
913

1014

@@ -13,5 +17,5 @@ class BoringView(TemplateView):
1317

1418

1519
urlpatterns = [
16-
url(r"^something", BoringView.as_view(), name="something"),
20+
path(r"^something", BoringView.as_view(), name="something"),
1721
]

0 commit comments

Comments
 (0)