Skip to content

Commit 7bead4e

Browse files
committed
Add required on_delete attribute, fixes no-value-for-parameter
since we're testing with latest Django versions this is now required for all ForeignKey fields
1 parent baa1637 commit 7bead4e

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

test/input/func_noerror_foreign_key_attributes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ class SomeModel(models.Model):
1212

1313

1414
class OtherModel(models.Model):
15-
something = models.ForeignKey(SomeModel)
16-
elsething = models.OneToOneField(SomeModel)
15+
something = models.ForeignKey(SomeModel, on_delete=models.CASCADE)
16+
elsething = models.OneToOneField(SomeModel, on_delete=models.CASCADE)
1717

1818
def something_doer(self):
1919
part_a = '%s - %s' % (self.something.name, self.something.timestamp)

test/input/func_noerror_foreign_key_ids.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class SomeModel(models.Model):
1010

1111

1212
class SomeOtherModel(models.Model):
13-
some_model = models.ForeignKey(SomeModel)
13+
some_model = models.ForeignKey(SomeModel, on_delete=models.CASCADE)
1414
number = models.IntegerField()
1515

1616
def do_something(self):

test/input/func_noerror_foreign_key_sets.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ def get_first(self):
1818

1919
class OtherModel(models.Model):
2020
count = models.IntegerField()
21-
something = models.ForeignKey(SomeModel)
21+
something = models.ForeignKey(SomeModel, on_delete=models.CASCADE)
2222

2323

2424
class ThirdModel(models.Model):
25-
whatever = models.ForeignKey(SomeModel, related_name='whatevs')
25+
whatever = models.ForeignKey(SomeModel, related_name='whatevs',
26+
on_delete=models.CASCADE)
2627

2728

2829
def count_whatevers():

test/input/func_noerror_foreignkeys.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ class ISBN(models.Model):
1717

1818
class Book(models.Model):
1919
book_name = models.CharField(max_length=100)
20-
author = models.ForeignKey(Author)
21-
isbn = models.OneToOneField(ISBN)
20+
author = models.ForeignKey(Author, on_delete=models.CASCADE)
21+
isbn = models.OneToOneField(ISBN, on_delete=models.CASCADE)
2222

2323
def get_isbn(self):
2424
return self.isbn.value
@@ -32,7 +32,7 @@ class Fruit(models.Model):
3232

3333

3434
class Seed(models.Model):
35-
fruit = ForeignKey(Fruit)
35+
fruit = ForeignKey(Fruit, on_delete=models.CASCADE)
3636

3737
def get_fruit_name(self):
3838
return self.fruit.fruit_name
@@ -43,7 +43,7 @@ class User(models.Model):
4343

4444

4545
class UserProfile(models.Model):
46-
user = OneToOneField(User)
46+
user = OneToOneField(User, on_delete=models.CASCADE)
4747

4848
def get_username(self):
4949
return self.user.username

0 commit comments

Comments
 (0)