Skip to content

Commit 8ca5572

Browse files
committed
[refs #49] Added test for accessing first() and last() on querysets, added in django1.6
1 parent e044f83 commit 8ca5572

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

pylint_django/augmentations/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,6 @@ def _visit_assign(checker):
346346

347347
def apply_augmentations(linter):
348348
"""Apply augmentation and suppression rules."""
349-
350349
augment_visit(linter, _visit_attribute(TypeChecker), foreign_key_sets)
351350
augment_visit(linter, _visit_attribute(TypeChecker), foreign_key_ids)
352351
suppress_message(linter, _visit_attribute(TypeChecker), 'E1101', is_model_field_display_method)
@@ -368,7 +367,6 @@ def apply_augmentations(linter):
368367
suppress_message(linter, _visit_class(ClassChecker), 'no-init', is_model_meta_subclass)
369368
suppress_message(linter, _leave_class(MisdesignChecker), 'too-few-public-methods', is_model_meta_subclass)
370369
suppress_message(linter, _visit_attribute(ClassChecker), 'protected-access', allow_meta_protected_access)
371-
#suppress_message(linter, _visit_assign(ClassChecker), 'protected-access', allow_meta_protected_access)
372370

373371
# Media
374372
suppress_message(linter, _visit_assignname(NameChecker), 'C0103', is_model_media_valid_attributes)

test/input/func_noerror_foreign_key_sets.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ class SomeModel(models.Model):
1212
def get_others(self):
1313
return self.othermodel_set.all()
1414

15+
def get_first(self):
16+
return self.othermodel_set.first()
17+
1518

1619
class OtherModel(models.Model):
1720
count = models.IntegerField()

test/input/func_noerror_model_methods.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,6 @@ class SomeModel(models.Model):
1414
MODEL.delete()
1515

1616
COUNT = SomeModel.objects.count()
17+
# added in django 1.6
18+
FIRST = SomeModel.objects.first()
19+
LAST = SomeModel.objects.last()

0 commit comments

Comments
 (0)