Add test import numpy

Author: PeterHamfelt

pylint_ml/__pkginfo__.py

@@ -9,22 +9,36 @@
 from astroid import nodes
 from pylint.checkers import BaseChecker
 from pylint.checkers.utils import only_required_for_messages
+from pylint.interfaces import HIGH
 
 
 class NumpyImportChecker(BaseChecker):
-    name = "numpy_import"
+    name = "numpy-import"
     msgs = {
-        "W8010": (
+        "W8001": (
             "Numpy imported with incorrect alias",
-            "numpy-imported-incorrectly",
+            "numpy-import",
             "Numpy should be imported with the alias `np` to maintain consistency with common practices. "
             "Importing numpy with any other alias can lead to confusion. "
             "Consider using `import numpy as np` for clarity and adherence to the convention.",
-        )
+        ),
+        "W8002": (
+            "Direct import from Numpy discouraged",
+            "numpy-importfrom",
+            "Direct imports from Numpy using `from numpy import ...` are discouraged to maintain code clarity and "
+            "prevent potential conflicts. Numpy should be imported with the alias `np` following common practices. "
+            "Using any other alias or direct import method can lead to confusion. "
+            "Consider using `import numpy as np` to adhere to the convention and ensure consistency.",
+        ),
     }
 
-    @only_required_for_messages("numpy_import")
+    @only_required_for_messages("numpy-import")
     def visit_import(self, node: nodes.Import) -> None:
         for name, alias in node.names:
             if name == "numpy" and alias != "np":
-                self.add_message("numpy_import", node=node)
+                self.add_message("numpy-import", node=node, confidence=HIGH)
+
+    @only_required_for_messages("numpy-importfrom")
+    def visit_importfrom(self, node: nodes.ImportFrom) -> None:
+        if node.modname == "numpy":
+            self.add_message("numpy-importfrom", node=node, confidence=HIGH)

pylint_ml/checkers/numpy/import_numpy.py

@@ -9,22 +9,36 @@
 from astroid import nodes
 from pylint.checkers import BaseChecker
 from pylint.checkers.utils import only_required_for_messages
+from pylint.interfaces import HIGH
 
 
 class PandasImportChecker(BaseChecker):
-    name = "pandas_import"
+    name = "pandas-import"
     msgs = {
-        "W8020": (
+        "W8001": (
             "Pandas imported with incorrect alias",
-            "pandas-imported-incorrectly",
+            "pandas-import",
             "Pandas should be imported with the alias `pd` to maintain consistency with common practices. "
             "Importing pandas with any other alias can lead to confusion. "
             "Consider using `import pandas as pd` for clarity and adherence to the convention.",
-        )
+        ),
+        "W8002": (
+            "Direct import from Pandas discouraged",
+            "pandas-importfrom",
+            "Direct imports from Pandas using `from pandas import ...` are discouraged to maintain code clarity and "
+            "prevent potential conflicts. Pandas should be imported with the alias `pd` following common practices. "
+            "Using any other alias or direct import method can lead to confusion. "
+            "Consider using `import pandas as pd` to adhere to the convention and ensure consistency.",
+        ),
     }
 
-    @only_required_for_messages("pandas_import")
+    @only_required_for_messages("pandas-import")
     def visit_import(self, node: nodes.Import) -> None:
         for name, alias in node.names:
             if name == "pandas" and alias != "pd":
-                self.add_message("pandas_import", node=node)
+                self.add_message("pandas-import", node=node, confidence=HIGH)
+
+    @only_required_for_messages("pandas-importfrom")
+    def visit_importfrom(self, node: nodes.ImportFrom) -> None:
+        if node.modname == "pandas":
+            self.add_message("pandas-importfrom", node=node, confidence=HIGH)

pylint_ml/checkers/pandas/import_pandas.py

@@ -0,0 +1,53 @@
+import astroid
+import pylint.testutils
+from pylint.interfaces import HIGH
+
+from pylint_ml.checkers.numpy.import_numpy import NumpyImportChecker
+
+
+class TestNumpyImport(pylint.testutils.CheckerTestCase):
+    CHECKER_CLASS = NumpyImportChecker
+
+    def test_correct_numpy_import(self):
+        import_node = astroid.extract_node(
+            """
+        import numpy as np
+        """
+        )
+
+        with self.assertNoMessages():
+            self.checker.visit_import(import_node)
+
+    def test_incorrect_numpy_import(self):
+        import_node = astroid.extract_node(
+            """
+        import numpy as npy
+        """
+        )
+
+        with self.assertAddsMessages(
+            pylint.testutils.MessageTest(
+                msg_id="numpy-import",
+                confidence=HIGH,
+                node=import_node,
+            ),
+            ignore_position=True,
+        ):
+            self.checker.visit_import(import_node)
+
+    def test_incorrect_numpy_import_from(self):
+        importfrom_node = astroid.extract_node(
+            """
+        from numpy import min
+        """
+        )
+
+        with self.assertAddsMessages(
+            pylint.testutils.MessageTest(
+                msg_id="numpy-importfrom",
+                confidence=HIGH,
+                node=importfrom_node,
+            ),
+            ignore_position=True,
+        ):
+            self.checker.visit_importfrom(importfrom_node)