Skip to content

Commit 1ad6d27

Browse files
author
Anis Da Silva Campos
committed
use .venv
1 parent 91a7acb commit 1ad6d27

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

.github/workflows/checks.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
id: cache-venv
5151
uses: actions/[email protected]
5252
with:
53-
path: venv
53+
path: .venv
5454
key: >-
5555
${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{
5656
steps.generate-python-key.outputs.key }}
@@ -88,7 +88,7 @@ jobs:
8888
id: cache-venv
8989
uses: actions/[email protected]
9090
with:
91-
path: venv
91+
path: .venv
9292
fail-on-cache-miss: true
9393
key: ${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{ needs.prepare-base.outputs.python-key }}
9494
- name: Restore pre-commit environment
@@ -102,5 +102,5 @@ jobs:
102102
run: make install
103103
- name: Run pylint checks
104104
run: |
105-
. venv/bin/activate
105+
. .venv/bin/activate
106106
pre-commit run pylint --all-files

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
# Use python executables inside venv
2-
export PATH := ./venv/bin:$(PATH)
2+
export PATH := .venv/bin:$(PATH)
33
export PYTHONPATH=.
44

55
# creates the venv
6-
venv/bin/python3.11:
7-
python3.11 -m venv venv
6+
.venv/bin/python3.11:
7+
python3.11 -m venv .venv
88

99
# makes sures the venv contains a given version of pip and pip-tools
10-
venv: venv/bin/python3.11
10+
.venv: .venv/bin/python3.11
1111
pip install --quiet --upgrade 'pip==23.3.1' 'pip-tools==7.3'
1212

1313
# generates a lock file with pinned version of all dependencies to be used by the CI and local devs
14-
dev-requirements.txt: venv dev-requirements.in setup.py
14+
dev-requirements.txt: .venv dev-requirements.in pyproject.toml
1515
pip-compile \
1616
--quiet --generate-hashes --max-rounds=20 --strip-extras \
1717
--resolver=backtracking \
1818
--output-file dev-requirements.txt \
19-
dev-requirements.in setup.cfg
19+
dev-requirements.in pyproject.toml
2020

2121
# upgrades the dependencies to their latest/matching version
22-
upgrade: venv
22+
upgrade: .venv
2323
pip-compile \
2424
--quiet --generate-hashes --max-rounds=20 --strip-extras \
2525
--upgrade \
@@ -30,8 +30,8 @@ upgrade: venv
3030

3131
# creates the venv if not present then install the dependencies, the package and pre-commit
3232
.PHONY: install
33-
install: venv
34-
pip-sync dev-requirements.txt
33+
install: .venv
34+
pip-sync dev-requirements.txt
3535
# install pylint_pytest (deps are already handled by the line before)
3636
pip install --no-deps -e .
3737
# install pre-commit hooks

0 commit comments

Comments
 (0)