Skip to content

Commit 3ab9d5e

Browse files
committed
fix: review changes
1 parent b87ae3f commit 3ab9d5e

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

.github/workflows/run-tests.yaml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,6 @@ jobs:
2525
- '3.10'
2626
- '3.11'
2727
- '3.12'
28-
include:
29-
- python-version: '3.8'
30-
tox_env: py38
31-
- python-version: '3.9'
32-
tox_env: py39
33-
- python-version: '3.10'
34-
tox_env: py310
35-
- python-version: '3.11'
36-
tox_env: py311
37-
- python-version: '3.12'
38-
tox_env: py312
3928

4029
defaults:
4130
run:
@@ -64,7 +53,8 @@ jobs:
6453
FORCE_COLOR: 1
6554
PYTEST_CI_ARGS: --cov-report=xml --cov-report=html --junitxml=test_artifacts/test_report.xml --color=yes
6655
run: |
67-
tox -e ${{ matrix.tox_env }}
56+
TOX_ENV=$(echo "py${{ matrix.python-version }}" | tr -d .)
57+
tox -e $TOX_ENV
6858
6959
- name: Upload coverage reports to Codecov
7060
uses: codecov/codecov-action@v3

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ paths.source = [
3636
]
3737

3838
[tool.mypy]
39-
python_version = "3.12"
39+
python_version = "3.8"
4040
check_untyped_defs = true
4141
explicit_package_bases = true
4242
namespace_packages = true
@@ -89,7 +89,7 @@ ignore = [
8989
"RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
9090
]
9191

92-
target-version = "py312"
92+
target-version = "py38"
9393

9494
[tool.ruff.pydocstyle]
9595
convention = "google"
@@ -112,7 +112,7 @@ convention = "google"
112112

113113
[tool.pylint]
114114

115-
py-version = "3.12"
115+
py-version = "3.8"
116116

117117
ignore-paths="tests/input" # Ignore test inputs
118118

0 commit comments

Comments
 (0)