tests: do not share CHECKER_CLASS

Author: reverbc

tests/base_tester.py

@@ -1,13 +1,12 @@
 import sys
 import os
 from pylint.testutils import CheckerTestCase
-from pylint.checkers.variables import VariablesChecker
 import astroid
 from pylint_pytest import register, unregister
 
 
-class BasePytestFixtureChecker(CheckerTestCase):
-    CHECKER_CLASS = VariablesChecker
+class BasePytestChecker(CheckerTestCase):
+    CHECKER_CLASS = None
     MSG_ID = None
     MESSAGES = None
 
@@ -28,7 +27,7 @@ def run_linter(self, enable_plugin, file_path=None):
 
             try:
                 self.walk(module)  # run all checkers
-                self.MESSAGES = self.linter.release_messages()
+                BasePytestChecker.MESSAGES = self.linter.release_messages()
             finally:
                 if enable_plugin:
                     unregister()

tests/test_redefined_outer_name.py

@@ -1,8 +1,10 @@
 import pytest
-from base_tester import BasePytestFixtureChecker
+from pylint.checkers.variables import VariablesChecker
+from base_tester import BasePytestChecker
 
 
-class TestRedefinedOuterName(BasePytestFixtureChecker):
+class TestRedefinedOuterName(BasePytestChecker):
+    CHECKER_CLASS = VariablesChecker
     MSG_ID = 'redefined-outer-name'
 
     @pytest.mark.parametrize('enable_plugin', [True, False])

tests/test_regression.py

@@ -1,10 +1,12 @@
 import pylint
 import pytest
-from base_tester import BasePytestFixtureChecker
+from pylint.checkers.variables import VariablesChecker
+from base_tester import BasePytestChecker
 
 
-class TestRegression(BasePytestFixtureChecker):
+class TestRegression(BasePytestChecker):
     '''Covering some behaviors that shouldn't get impacted by the plugin'''
+    CHECKER_CLASS = VariablesChecker
     MSG_ID = 'regression'
 
     @pytest.mark.parametrize('enable_plugin', [True, False])

tests/test_unused_argument.py

@@ -1,8 +1,10 @@
 import pytest
-from base_tester import BasePytestFixtureChecker
+from pylint.checkers.variables import VariablesChecker
+from base_tester import BasePytestChecker
 
 
-class TestUnusedArgument(BasePytestFixtureChecker):
+class TestUnusedArgument(BasePytestChecker):
+    CHECKER_CLASS = VariablesChecker
     MSG_ID = 'unused-argument'
 
     @pytest.mark.parametrize('enable_plugin', [True, False])

tests/test_unused_import.py

@@ -1,8 +1,10 @@
 import pytest
-from base_tester import BasePytestFixtureChecker
+from pylint.checkers.variables import VariablesChecker
+from base_tester import BasePytestChecker
 
 
-class TestUnusedImport(BasePytestFixtureChecker):
+class TestUnusedImport(BasePytestChecker):
+    CHECKER_CLASS = VariablesChecker
     MSG_ID = 'unused-import'
 
     @pytest.mark.parametrize('enable_plugin', [True, False])