Skip to content

Commit 18cc751

Browse files
committed
Fix regression in unnecessary-lambda-assignment check
1 parent dd1dea3 commit 18cc751

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

pylint/checkers/lambda_expressions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,15 @@ def visit_assign(self, node: nodes.Assign) -> None:
4141
"""Check if lambda expression is assigned to a variable."""
4242
match node:
4343
case nodes.Assign(
44-
targets=[nodes.AssignName()], value=nodes.Lambda() as value
44+
targets=[nodes.AssignName(), *_], value=nodes.Lambda() as value
4545
):
4646
self.add_message(
4747
"unnecessary-lambda-assignment",
4848
node=value,
4949
confidence=HIGH,
5050
)
5151
case nodes.Assign(
52-
targets=[nodes.Tuple() as target],
52+
targets=[nodes.Tuple() as target, *_],
5353
value=nodes.Tuple() | nodes.List() as value,
5454
):
5555
# Iterate over tuple unpacking assignment elements and

tests/functional/u/unnecessary/unnecessary_lambda_assignment.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@
3737
if (e := lambda: 2) and e(): # [unnecessary-lambda-assignment]
3838
pass
3939

40-
# Skip checking multi-assignments
41-
a = b = lambda: None
42-
a, b = x = lambda: None, None
40+
# Multi-assignments
41+
a = b = lambda: None # [unnecessary-lambda-assignment]
42+
a, b = x = lambda: None, None # [unnecessary-lambda-assignment]

tests/functional/u/unnecessary/unnecessary_lambda_assignment.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,5 @@ unnecessary-lambda-assignment:23:4:23:15:<lambda>:"Lambda expression assigned to
1313
unnecessary-lambda-assignment:26:10:26:21:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
1414
unnecessary-lambda-assignment:26:23:26:34:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
1515
unnecessary-lambda-assignment:37:9:37:18:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
16+
unnecessary-lambda-assignment:41:8:41:20:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH
17+
unnecessary-lambda-assignment:42:11:42:23:<lambda>:"Lambda expression assigned to a variable. Define a function using the ""def"" keyword instead.":HIGH

0 commit comments

Comments
 (0)