Add functional test for NewType member checking

#3162

Author: colatkinson

CONTRIBUTORS.txt

@@ -595,3 +595,5 @@ contributors:
 * Eero Vuojolahti: contributor
 
 * Kian-Meng, Ang: contributor
+
+* Colin Atkinson (colatkinson): contributor

tests/functional/a/arguments.py

@@ -260,3 +260,13 @@ def func(one, two, three):
 
 
 CALL = lambda *args: func(*args)
+
+
+# Check that typing.NewType calls expect exactly one argument
+import typing
+
+
+ChildType = typing.NewType("AliasType", int)
+ChildType()  # [no-value-for-parameter]
+ChildType(1)
+ChildType(1, 2)  # [too-many-function-args]

tests/functional/a/arguments.txt

@@ -37,3 +37,5 @@ unexpected-keyword-arg:202:23:202:56:namedtuple_replace_issue_1036:Unexpected ke
 no-value-for-parameter:215:0:215:24::No value for argument 'third' in function call:UNDEFINED
 no-value-for-parameter:216:0:216:30::No value for argument 'second' in function call:UNDEFINED
 unexpected-keyword-arg:217:0:217:43::Unexpected keyword argument 'fourth' in function call:UNDEFINED
+no-value-for-parameter:270:0:270:11::No value for argument 'val' in constructor call:UNDEFINED
+too-many-function-args:272:0:272:15::Too many positional arguments for constructor call:UNDEFINED

tests/functional/m/member/member_checks.py

@@ -231,3 +231,44 @@ class Animal(Enum):
     print(keyy)
 for vall in Animal.__members__.values():
     print(vall)
+
+
+# Test for false positives on NewType classes
+from typing import NewType
+
+UserId = NewType("UserId", str)
+
+some_id = UserId("id")
+some_id.capitalize()
+some_id.not_a_str_method()  # [no-member]
+
+
+class BaseClass:
+    def __init__(self, value):
+        self.value = value
+
+
+ChildClass = NewType("ChildClass", BaseClass)
+
+
+base = BaseClass(5)
+base.value
+base.bad_attr  # [no-member]
+
+
+child = ChildClass(base)
+child.value
+child.bad_attr  # [no-member]
+
+
+import pathlib
+
+PathChild = NewType("PathChild", pathlib.PurePath)
+
+path = pathlib.PurePath("/")
+path.root
+path.bad_attr  # [no-member]
+
+path_child = PathChild(path)
+path_child.root
+path_child.bad_attr  # [no-member]

tests/functional/m/member/member_checks.txt

@@ -17,3 +17,8 @@ no-member:135:0:135:18::Class 'str' has no 'portocala' member:INFERENCE
 no-member:170:19:170:32:NoDunderNameInInstance.__init__:Instance of 'NoDunderNameInInstance' has no '__name__' member:INFERENCE
 no-member:176:14:176:23:InvalidAccessBySlots.__init__:Instance of 'InvalidAccessBySlots' has no 'teta' member:INFERENCE
 no-member:208:13:208:20::Class 'Cls' has no 'BAZ' member; maybe 'BAR'?:INFERENCE
+no-member:243:0:243:24::Instance of 'UserId' has no 'not_a_str_method' member:INFERENCE
+no-member:256:0:256:13::Instance of 'BaseClass' has no 'bad_attr' member:INFERENCE
+no-member:261:0:261:14::Instance of 'ChildClass' has no 'bad_attr' member:INFERENCE
+no-member:270:0:270:13::Instance of 'PurePath' has no 'bad_attr' member:INFERENCE
+no-member:274:0:274:19::Instance of 'PathChild' has no 'bad_attr' member:INFERENCE