consider-using-with now triggers for pathlib.Path.open (#7968)

Author: GideonBear

doc/whatsnew/fragments/7964.false_negative

@@ -0,0 +1,3 @@
+``consider-using-with`` now triggers for ``pathlib.Path.open``.
+
+Closes #7964

pylint/checkers/refactoring/refactoring_checker.py

@@ -49,6 +49,7 @@
 CALLS_RETURNING_CONTEXT_MANAGERS = frozenset(
     (
         "_io.open",  # regular 'open()' call
+        "pathlib.Path.open",
         "codecs.open",
         "urllib.request.urlopen",
         "tempfile.NamedTemporaryFile",

tests/functional/c/consider/consider_using_with.py

@@ -2,13 +2,24 @@
 import codecs
 import contextlib
 import multiprocessing
+import pathlib
 import subprocess
 import tarfile
 import tempfile
 import threading
 import urllib
 import zipfile
 from concurrent.futures import ThreadPoolExecutor, ProcessPoolExecutor
+from pathlib import Path
+
+
+def test_pathlib_open():
+    _ = pathlib.Path("foo").open(encoding="utf8")  # [consider-using-with]
+    _ = Path("foo").open(encoding="utf8")  # [consider-using-with]
+    path = Path("foo")
+    _ = path.open(encoding="utf8")  # [consider-using-with]
+    with Path("foo").open(encoding="utf8") as file:  # must not trigger
+        _ = file.read()
 
 
 def test_codecs_open():

tests/functional/c/consider/consider_using_with.txt

@@ -1,25 +1,28 @@
-consider-using-with:15:9:15:40:test_codecs_open:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:20:8:20:55:test_urlopen:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:28:8:28:40:test_named_temporary_file:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:32:8:32:42:test_spooled_temporary_file:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:36:8:36:37:test_temporary_directory:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:40:12:40:44:test_zipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:41:8:41:30:test_zipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:45:12:45:46:test_pyzipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:50:8:50:30:test_pyzipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:57:9:57:43:test_tarfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:63:9:63:47:test_tarfile:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:72:4:72:18:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:79:4:79:19:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:86:4:86:18:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:93:4:93:26:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:129:8:129:30:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:134:4:134:19:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:139:4:139:19:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:145:8:145:30:test_popen:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:201:4:201:26::Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:202:4:202:26::Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:207:4:207:26::Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:17:8:17:49:test_pathlib_open:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:18:8:18:41:test_pathlib_open:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:20:8:20:34:test_pathlib_open:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:26:9:26:40:test_codecs_open:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:31:8:31:55:test_urlopen:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:39:8:39:40:test_named_temporary_file:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:43:8:43:42:test_spooled_temporary_file:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:47:8:47:37:test_temporary_directory:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:51:12:51:44:test_zipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:52:8:52:30:test_zipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:56:12:56:46:test_pyzipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:61:8:61:30:test_pyzipfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:68:9:68:43:test_tarfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:74:9:74:47:test_tarfile:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:83:4:83:18:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:90:4:90:19:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:97:4:97:18:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:104:4:104:26:test_lock_acquisition:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:140:8:140:30:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:145:4:145:19:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:150:4:150:19:test_multiprocessing:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:156:8:156:30:test_popen:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:212:4:212:26::Consider using 'with' for resource-allocating operations:UNDEFINED
 consider-using-with:213:4:213:26::Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:229:18:229:40:test_subscript_assignment:Consider using 'with' for resource-allocating operations:UNDEFINED
-consider-using-with:231:24:231:46:test_subscript_assignment:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:218:4:218:26::Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:224:4:224:26::Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:240:18:240:40:test_subscript_assignment:Consider using 'with' for resource-allocating operations:UNDEFINED
+consider-using-with:242:24:242:46:test_subscript_assignment:Consider using 'with' for resource-allocating operations:UNDEFINED