Move the function go retrieve test file to pylint.testutil.functional

Author: Pierre-Sassoulas

pylint/testutils/functional/__init__.py

@@ -3,10 +3,16 @@
 
 __all__ = [
     "FunctionalTestFile",
+    "REASONABLY_DISPLAYABLE_VERTICALLY",
+    "get_functional_test_files_from_directory",
     "NoFileError",
     "parse_python_version",
 ]
 
+from pylint.testutils.functional.find_functional_tests import (
+    REASONABLY_DISPLAYABLE_VERTICALLY,
+    get_functional_test_files_from_directory,
+)
 from pylint.testutils.functional.test_file import (
     FunctionalTestFile,
     NoFileError,

pylint/testutils/functional/find_functional_tests.py

@@ -0,0 +1,30 @@
+# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+# For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
+
+import os
+from pathlib import Path
+from typing import List, Union
+
+from pylint.testutils.functional.test_file import FunctionalTestFile
+
+# 'Wet finger' number of files that are reasonable to display by an IDE
+# 'Wet finger' as in 'in my settings there are precisely this many'.
+REASONABLY_DISPLAYABLE_VERTICALLY = 48
+
+
+def get_functional_test_files_from_directory(
+    input_dir: Union[Path, str]
+) -> List[FunctionalTestFile]:
+    suite = []
+    for dirpath, _, filenames in os.walk(input_dir):
+        if dirpath.endswith("__pycache__"):
+            continue
+
+        assert (
+            len(filenames) <= REASONABLY_DISPLAYABLE_VERTICALLY
+        ), f"{dirpath} contain too much functional tests files."
+
+        for filename in filenames:
+            if filename != "__init__.py" and filename.endswith(".py"):
+                suite.append(FunctionalTestFile(dirpath, filename))
+    return suite

tests/test_functional.py

@@ -26,23 +26,24 @@
 import os
 import sys
 from pathlib import Path
-from typing import List, Union
+from typing import Union
 
 import pytest
 from _pytest.config import Config
 from _pytest.recwarn import WarningsRecorder
 
 from pylint import testutils
 from pylint.testutils import UPDATE_FILE, UPDATE_OPTION
-from pylint.testutils.functional.test_file import FunctionalTestFile
+from pylint.testutils.functional import (
+    FunctionalTestFile,
+    get_functional_test_files_from_directory,
+)
 from pylint.utils import HAS_ISORT_5
 
 # TODOs
 #  - implement exhaustivity tests
 
-# 'Wet finger' number of files that are reasonable to display by an IDE
-# 'Wet finger' as in 'in my settings there are precisely this many'.
-REASONABLY_DISPLAYABLE_VERTICALLY = 48
+
 FUNCTIONAL_DIR = Path(__file__).parent.resolve() / "functional"
 
 
@@ -66,24 +67,6 @@ def _check_output_text(self, _, expected_output, actual_output):
                 writer.writerow(line.to_csv())
 
 
-def get_functional_test_files_from_directory(
-    input_dir: Union[Path, str]
-) -> List[FunctionalTestFile]:
-    suite = []
-    for dirpath, _, filenames in os.walk(input_dir):
-        if dirpath.endswith("__pycache__"):
-            continue
-
-        assert (
-            len(filenames) <= REASONABLY_DISPLAYABLE_VERTICALLY
-        ), f"{dirpath} contain too much functional tests files."
-
-        for filename in filenames:
-            if filename != "__init__.py" and filename.endswith(".py"):
-                suite.append(testutils.FunctionalTestFile(dirpath, filename))
-    return suite
-
-
 # isort 5 has slightly different rules as isort 4. Testing both would be hard: test with isort 5 only.
 TESTS = [
     t