Add typing to checker and plugin attributes of PyLinter (#5574)

Author: DanielNoord

pylint/lint/pylinter.py

@@ -11,7 +11,19 @@
 import traceback
 import warnings
 from io import TextIOWrapper
-from typing import Any, Dict, Iterable, Iterator, List, Optional, Sequence, Type, Union
+from typing import (
+    Any,
+    DefaultDict,
+    Dict,
+    Iterable,
+    Iterator,
+    List,
+    Optional,
+    Sequence,
+    Set,
+    Type,
+    Union,
+)
 
 import astroid
 from astroid import AstroidError, nodes
@@ -537,8 +549,15 @@ def __init__(
         self._reporters: Dict[str, Type[reporters.BaseReporter]] = {}
         """Dictionary of possible but non-initialized reporters"""
 
+        # Attributes for checkers and plugins
+        self._checkers: DefaultDict[
+            str, List[checkers.BaseChecker]
+        ] = collections.defaultdict(list)
+        """Dictionary of registered and initialized checkers"""
+        self._dynamic_plugins: Set[str] = set()
+        """Set of loaded plugin names"""
+
         self.msgs_store = MessageDefinitionStore()
-        self._checkers = collections.defaultdict(list)
         self._pragma_lineno = {}
 
         # Attributes related to visiting files
@@ -585,7 +604,6 @@ def __init__(
             ("RP0003", "Messages", report_messages_stats),
         )
         self.register_checker(self)
-        self._dynamic_plugins = set()
         self._error_mode = False
         self.load_provider_defaults()
 
@@ -722,7 +740,7 @@ def report_order(self):
 
     # checkers manipulation methods ############################################
 
-    def register_checker(self, checker):
+    def register_checker(self, checker: checkers.BaseChecker) -> None:
         """register a new checker
 
         checker is an object implementing IRawChecker or / and IAstroidChecker

pylint/reporters/reports_handler_mix_in.py

@@ -4,15 +4,15 @@
 import collections
 from typing import TYPE_CHECKING, Callable, DefaultDict, Dict, List, Optional, Tuple
 
+from pylint import checkers
 from pylint.exceptions import EmptyReportError
-from pylint.interfaces import IChecker
 from pylint.reporters.ureports.nodes import Section
 from pylint.utils import LinterStats
 
 if TYPE_CHECKING:
     from pylint.lint.pylinter import PyLinter
 
-ReportsDict = DefaultDict[IChecker, List[Tuple[str, str, Callable]]]
+ReportsDict = DefaultDict[checkers.BaseChecker, List[Tuple[str, str, Callable]]]
 
 
 class ReportsHandlerMixIn:
@@ -24,12 +24,12 @@ def __init__(self) -> None:
         self._reports: ReportsDict = collections.defaultdict(list)
         self._reports_state: Dict[str, bool] = {}
 
-    def report_order(self) -> List[IChecker]:
+    def report_order(self) -> List[checkers.BaseChecker]:
         """Return a list of reporters"""
         return list(self._reports)
 
     def register_report(
-        self, reportid: str, r_title: str, r_cb: Callable, checker: IChecker
+        self, reportid: str, r_title: str, r_cb: Callable, checker: checkers.BaseChecker
     ) -> None:
         """register a report