Use sorted() instead of in-place sorting (#10603)

Author: vil02

pylint/checkers/symilar.py

@@ -430,8 +430,7 @@ def _compute_sims(self) -> list[tuple[int, set[LinesChunkLimits_T]]]:
             cpls: set[LinesChunkLimits_T]
             for cpls in ensembles:
                 sims.append((num, cpls))
-        sims.sort(reverse=True)
-        return sims
+        return sorted(sims, reverse=True)
 
     def _display_sims(
         self, similarities: list[tuple[int, set[LinesChunkLimits_T]]]

pylint/message/message_id_store.py

@@ -102,23 +102,21 @@ def check_msgid_and_symbol(self, msgid: str, symbol: str) -> None:
     @staticmethod
     def _raise_duplicate_symbol(msgid: str, symbol: str, other_symbol: str) -> NoReturn:
         """Raise an error when a symbol is duplicated."""
-        symbols = [symbol, other_symbol]
-        symbols.sort()
-        error_message = f"Message id '{msgid}' cannot have both "
-        error_message += f"'{symbols[0]}' and '{symbols[1]}' as symbolic name."
-        raise InvalidMessageError(error_message)
+        symbol_a, symbol_b = sorted([symbol, other_symbol])
+        raise InvalidMessageError(
+            f"Message id '{msgid}' cannot have both "
+            f"'{symbol_a}' and '{symbol_b}' as symbolic name."
+        )
 
     @staticmethod
     def _raise_duplicate_msgid(symbol: str, msgid: str, other_msgid: str) -> NoReturn:
         """Raise an error when a msgid is duplicated."""
-        msgids = [msgid, other_msgid]
-        msgids.sort()
-        error_message = (
+        msgid_a, msgid_b = sorted([msgid, other_msgid])
+        raise InvalidMessageError(
             f"Message symbol '{symbol}' cannot be used for "
-            f"'{msgids[0]}' and '{msgids[1]}' at the same time."
+            f"'{msgid_a}' and '{msgid_b}' at the same time."
             f" If you're creating an 'old_names' use 'old-{symbol}' as the old symbol."
         )
-        raise InvalidMessageError(error_message)
 
     def get_active_msgids(self, msgid_or_symbol: str) -> list[str]:
         """Return msgids but the input can be a symbol.