Add todo note because infering type in Aggregation comprehensions is unreliable for now

Author: Julfried

pylint/pyreverse/inspector.py

@@ -396,6 +396,7 @@ def handle(self, node: nodes.AssignAttr, parent: nodes.ClassDef) -> None:
             return
 
         # Aggregation: comprehensions without object creation (self.x = [existing_obj for ...])
+        # TODO: Currently inferring type of existing_obj is not reliable ==> improve once astroid supports it
         if isinstance(
             value, (nodes.ListComp, nodes.DictComp, nodes.SetComp, nodes.GeneratorExp)
         ):

tests/pyreverse/functional/class_diagrams/associations/comprehensions.mmd

@@ -8,12 +8,6 @@ classDiagram
     components_set : set[Component]
     lazy_components : Generator[Component]
   }
-  class AggregationContainer {
-    components : list[Component]
-    component_dict : dict[str, Component]
-    components_set : set[Component]
-    lazy_components : Generator[Component]
-  }
   class CompositionContainer {
     components : list[Component]
     component_dict : dict[int, Component]
@@ -24,11 +18,7 @@ classDiagram
   Component --> AssociationContainer : component_dict
   Component --> AssociationContainer : components_set
   Component --> AssociationContainer : lazy_components
-  Component --o AggregationContainer : components
-  Component --o AggregationContainer : component_dict
-  Component --o AggregationContainer : components_set
-  Component --o AggregationContainer : lazy_components
   Component --* CompositionContainer : components
   Component --* CompositionContainer : component_dict
   Component --* CompositionContainer : components_set
-  Component --* CompositionContainer : lazy_components
+  Component --* CompositionContainer : lazy_components

tests/pyreverse/functional/class_diagrams/associations/comprehensions.py

@@ -1,31 +1,21 @@
 # Test for https://github.com/pylint-dev/pylint/issues/10236
 from collections.abc import Generator
+from dataclasses import dataclass
 
 
 class Component:
     """A component class."""
     def __init__(self, name: str):
         self.name = name
 
-
 class AssociationContainer:
     """Type hints only - no ownership."""
-    # Association: just type hints, no actual assignment
-    components: list[Component]
-    component_dict: dict[int, Component]
-    components_set: set[Component]
-    lazy_components: Generator[Component]
-
-
-class AggregationContainer:
-    """Comprehensions using existing objects - aggregation."""
-    def __init__(self, existing_components: list[Component]):
-        # Aggregation: comprehensions using existing objects (not creating)
-        self.components: list[Component] = [comp for comp in existing_components]
-        self.component_dict: dict[str, Component] = {f"key_{i}": comp for i, comp in enumerate(existing_components)}
-        self.components_set: set[Component] = {comp for comp in existing_components}
-        self.lazy_components: Generator[Component] = (comp for comp in existing_components)
-
+    def __init__(self):
+        # Association: just type hints, no actual assignment
+        self.components: list[Component]
+        self.component_dict: dict[int, Component]
+        self.components_set: set[Component]
+        self.lazy_components: Generator[Component]
 
 class CompositionContainer:
     """Comprehensions creating new objects - composition."""
@@ -34,4 +24,4 @@ def __init__(self):
         self.components: list[Component] = [Component(f"component_{i}") for i in range(3)]
         self.component_dict: dict[int, Component] = {i: Component(f"dict_component_{i}") for i in range(2)}
         self.components_set: set[Component] = {Component(f"set_component_{i}") for i in range(2)}
-        self.lazy_components: Generator[Component] = (Component(f"lazy_{i}") for i in range(2))
+        self.lazy_components: Generator[Component] = (Component(f"lazy_{i}") for i in range(2))