[ruff] Activate flake8-pie and fix existing issues

Author: Pierre-Sassoulas

doc/test_messages_documentation.py

@@ -140,7 +140,7 @@ def get_expected_messages(stream: TextIO) -> MessageCounter:
             line = match.group("line")
             if line is None:
                 lineno = i + 1
-            elif line.startswith("+") or line.startswith("-"):
+            elif line.startswith(("+", "-")):
                 lineno = i + 1 + int(line)
             else:
                 lineno = int(line)

pylint/checkers/base/name_checker/checker.py

@@ -688,7 +688,7 @@ def _check_typevar(self, name: str, node: nodes.AssignName) -> None:
                 confidence=interfaces.INFERENCE,
             )
         elif variance == TypeVarVariance.invariant and (
-            name.endswith("_co") or name.endswith("_contra")
+            name.endswith(("_co", "_contra"))
         ):
             suggest_name = re.sub("_contra$|_co$", "", name)
             self.add_message(

pylint/checkers/similar.py

@@ -647,10 +647,10 @@ def _get_functions(
         line = line.strip()
         if ignore_docstrings:
             if not docstring:
-                if line.startswith('"""') or line.startswith("'''"):
+                if line.startswith(('"""', "'''")):
                     docstring = line[:3]
                     line = line[3:]
-                elif line.startswith('r"""') or line.startswith("r'''"):
+                elif line.startswith(('r"""', "r'''")):
                     docstring = line[1:4]
                     line = line[4:]
             if docstring:

pylint/checkers/unicode.py

@@ -375,7 +375,7 @@ class UnicodeChecker(checkers.BaseRawFileChecker):
 
     @staticmethod
     def _is_invalid_codec(codec: str) -> bool:
-        return codec.startswith("utf-16") or codec.startswith("utf-32")
+        return codec.startswith(("utf-16", "utf-32"))
 
     @staticmethod
     def _is_unicode(codec: str) -> bool:

pylint/config/config_initialization.py

@@ -169,7 +169,7 @@ def _order_all_first(config_args: list[str], *, joined: bool) -> list[str]:
     all_action = ""
 
     for i, arg in enumerate(config_args):
-        if joined and (arg.startswith("--enable=") or arg.startswith("--disable=")):
+        if joined and (arg.startswith(("--enable=", "--disable="))):
             value = arg.split("=")[1]
         elif arg in {"--enable", "--disable"}:
             value = config_args[i + 1]

pylint/testutils/lint_module_test.py

@@ -172,7 +172,7 @@ def get_expected_messages(stream: TextIO) -> MessageCounter:
             line = match.group("line")
             if line is None:
                 lineno = i + 1
-            elif line.startswith("+") or line.startswith("-"):
+            elif line.startswith(("+", "-")):
                 lineno = i + 1 + int(line)
             else:
                 lineno = int(line)

pyproject.toml

@@ -150,6 +150,7 @@ select = [
     "E",  # pycodestyle
     "F",  # pyflakes
     "I",  # isort
+    "PIE", # flake8-pie
     "PYI", # flake8-pyi
     "UP", # pyupgrade
     "RUF", # ruff