[functional tests] Only count python files for the reasonably displayable limit #10490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nably displayable limit
Pierre-Sassoulas
added
the
Maintenance
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cdce8p
force-pushed
the
less-constraint-on-functional-tests-structure
branch
from
5784fd7 to
ae1e433
Compare
cdce8p
reviewed
Aug 15, 2025
| @@ -11,17 +11,19 @@ | |||
| from pylint.testutils.functional.test_file import FunctionalTestFile | |||
|
|
|||
| REASONABLY_DISPLAYABLE_VERTICALLY = 49 | |||
There was a problem hiding this comment.
Should we adjust the limit here? If I set it to 20, this is the output
E AssertionError: The following directory contains too many functional tests files:
E - /.../pylint/tests/functional: 21 when the max is 20
E - /.../pylint/tests/functional/r/regression_02: 33 when the max is 20
E - /.../pylint/tests/functional/r/regression: 37 when the max is 20
E - /.../pylint/tests/functional/n: 26 when the max is 20
E - /.../pylint/tests/functional/n/no: 22 when the max is 20
E - /.../pylint/tests/functional/b: 22 when the max is 20
E - /.../pylint/tests/functional/ext: 26 when the max is 20
E - /.../pylint/tests/functional/u: 27 when the max is 20
E - /.../pylint/tests/functional/u/unused: 24 when the max is 20
E - /.../pylint/tests/functional/u/used: 26 when the max is 20
E - /.../pylint/tests/functional/t/too: 22 when the max is 20
E - /.../pylint/tests/functional/c: 23 when the max is 20
E - /.../pylint/tests/functional/w: 24 when the max is 20
E - /.../pylint/tests/functional/i: 21 when the max is 20
E - /.../pylint/tests/functional/i/invalid: 24 when the max is 20
E - /.../pylint/tests/functional/s: 26 when the max is 20Good to see that u/used now only counts as 26 when it hit the limit before.
There was a problem hiding this comment.
My ide now handle 33 file names vertically now, if you want a new arbitrary number that will prevent having too much work to do right now 😄 (but it doesn't make much sense to base the value on that now). Round number like 40 maybe ?
| @@ -86,7 +90,6 @@ def walk(path: Path) -> Iterator[Path]: | |||
| ) | |||
| for _file_or_dir in parent_dir_files: | |||
| if _file_or_dir.is_dir(): | |||
| _files = _get_files_from_dir(_file_or_dir, violations) | |||
There was a problem hiding this comment.
_files here isn't used anywhere. Instead this line lead to a duplicate warning for subpackages which are walked anyway a few lines below. Example output from one of the tests:
The following directory contains too many functional tests files:
- /.../pylint/tests/testutils/data/m: 3 when the max is 1
- /.../pylint/tests/testutils/data/m/max_overflow: 2 when the max is 1
- /.../pylint/tests/testutils/data/m/max_overflow: 2 when the max is 1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10490 +/- ##
==========================================
- Coverage 95.85% 95.85% -0.01%
==========================================
Files 177 177
Lines 19199 19198 -1
==========================================
- Hits 18403 18402 -1
Misses 796 796
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 15a3527 |
cdce8p
approved these changes
Aug 15, 2025
Pierre-Sassoulas
deleted the
less-constraint-on-functional-tests-structure
branch
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs #10488