fix: silence error messages when sampler is dropped

Author: aseyboldt

python/nutpie/sample.py

@@ -305,10 +305,10 @@ def in_marimo_notebook() -> bool:
 
 def _mo_write_internal(cell_id, stream, value: object) -> None:
     """Write to marimo cell given cell_id and stream."""
-    from marimo._output import formatting
+    from marimo._messaging.cell_output import CellChannel
     from marimo._messaging.ops import CellOp
     from marimo._messaging.tracebacks import write_traceback
-    from marimo._messaging.cell_output import CellChannel
+    from marimo._output import formatting
 
     output = formatting.try_format(value)
     if output.traceback is not None:
@@ -325,9 +325,9 @@ def _mo_write_internal(cell_id, stream, value: object) -> None:
 
 def _mo_create_replace():
     """Create mo.output.replace with current context pinned."""
+    from marimo._output import formatting
     from marimo._runtime.context import get_context
     from marimo._runtime.context.types import ContextNotInitializedError
-    from marimo._output import formatting
 
     try:
         ctx = get_context()
@@ -525,9 +525,9 @@ def _extract(self, results):
             return results
         else:
             if results.is_zarr():
-                from zarr.storage import ObjectStore
                 import obstore
                 import xarray as xr
+                from zarr.storage import ObjectStore
 
                 assert self._zarr_store is not None
 
@@ -604,7 +604,9 @@ def cancel(self):
         self._sampler.abort()
 
     def __del__(self):
-        if not self._sampler.is_empty():
+        if not hasattr(self, "_sampler"):
+            return
+        if not self._sampler.is_empty(ignore_error=True):
             self.cancel()
 
     def _repr_html_(self):

src/wrapper.rs

@@ -1232,11 +1232,16 @@ impl PySampler {
         })
     }
 
-    fn is_empty(&self) -> bool {
-        matches!(
-            self.0.lock().expect("Poisoned sampler state lock").deref(),
-            (SamplerState::Empty, _)
-        )
+    #[pyo3(signature = (ignore_error=false))]
+    fn is_empty(&self, ignore_error: bool) -> Result<bool> {
+        let out = self.0.lock();
+        match (ignore_error, out) {
+            (false, Err(e)) => return Err(anyhow!("The sampler panicked with error {}", e)),
+            (true, Err(_)) => return Ok(true),
+            (_, Ok(v)) => {
+                return Ok(matches!(v.deref(), (SamplerState::Empty, _)));
+            }
+        }
     }
 
     fn flush<'py>(&mut self, py: Python<'py>) -> PyResult<()> {