Skip to content

Commit ef32b87

Browse files
committed
Corrections in the notebook and add a small comment in DFM.py
1 parent b659d61 commit ef32b87

File tree

2 files changed

+639
-579
lines changed

2 files changed

+639
-579
lines changed

notebooks/DFM_Example_(Coincident_Index).ipynb

Lines changed: 637 additions & 579 deletions
Large diffs are not rendered by default.

pymc_extras/statespace/models/DFM.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,7 @@ def make_symbolic_graph(self):
620620
if len(matrix_parts) == 1:
621621
design_matrix = factor_loadings * 1.0 # copy to ensure a new PyTensor variable
622622
design_matrix.name = "design"
623+
# TODO: This is a hack to ensure the design matrix isn't identically equal to the factor_loadings when error_order=0 and factor_order=0
623624
else:
624625
design_matrix = pt.concatenate(matrix_parts, axis=1)
625626
design_matrix.name = "design"
@@ -654,6 +655,7 @@ def make_symbolic_graph(self):
654655
# Construction with block-diagonal structure:
655656
# Each latent component (factors, errors, exogenous states) contributes its own transition block,
656657
# and the full transition matrix is assembled with block_diag.
658+
# T = block_diag(A, B, C)
657659
#
658660
# - Factors (block A):
659661
# If factor_order > 0, the factor AR coefficients are organized into a

0 commit comments

Comments
 (0)