Skip to content

Commit 135de02

Browse files
committed
add note
1 parent 74d14d8 commit 135de02

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pymc3/gp/gp.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,14 @@ def _build_conditional(self, Xnew, X, y, noise, cov_total, mean_total,
210210
return mu, stabilize(cov)
211211

212212
def _get_cond_vals(self, other=None):
213+
# LOOK AT THIS MORE, where to X, y, noise need to come from? depending on situation
214+
# provide this function with **kwargs and return those if given? X=X, y=y, etc
215+
# i think this would be good. could build the gp "from scratch". caching these
216+
# from prior or marglike is a convenience
213217
if other is None:
214218
return self.X, self.y, self.noise, self.cov_func, self.mean_func,
215219
else:
216-
return other.X, other.y, other.noise, other.cov_func, other.mean_func
220+
return self.X, self.y, self.noise, other.cov_func, other.mean_func
217221

218222
def conditional(self, name, n_points, Xnew, given=None, pred_noise=False):
219223
# try to get n_points from X, (via cast to int?), error if cant and n_points is none

0 commit comments

Comments
 (0)