Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Sep 18, 2023

This simplifies the rewrite logic quite a bit and fixes #6917


📚 Documentation preview 📚: https://pymc--6918.org.readthedocs.build/en/6918/

@ricardoV94 ricardoV94 force-pushed the fix_custom_dist_inplace branch 5 times, most recently from 671a2c0 to 8c02380 Compare September 21, 2023 23:46
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: Patch coverage is 58.63454% with 309 lines in your changes missing coverage. Please review.

Project coverage is 63.19%. Comparing base (ec4407d) to head (ff59803).
Report is 462 commits behind head on main.

Files with missing lines Patch % Lines
pymc/distributions/transforms.py 53.17% 162 Missing ⚠️
pymc/logprob/scan.py 9.25% 49 Missing ⚠️
pymc/logprob/mixture.py 21.73% 18 Missing ⚠️
pymc/logprob/transforms.py 64.00% 18 Missing ⚠️
pymc/logprob/tensor.py 46.15% 14 Missing ⚠️
pymc/pytensorf.py 65.00% 14 Missing ⚠️
pymc/logprob/basic.py 76.19% 10 Missing ⚠️
pymc/logprob/abstract.py 70.83% 7 Missing ⚠️
pymc/logprob/utils.py 91.66% 6 Missing ⚠️
pymc/logprob/binary.py 40.00% 3 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (ec4407d) and HEAD (ff59803). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (ec4407d) HEAD (ff59803)
14 5
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6918       +/-   ##
===========================================
- Coverage   87.78%   63.19%   -24.59%     
===========================================
  Files         100      100               
  Lines       16896    16736      -160     
===========================================
- Hits        14832    10577     -4255     
- Misses       2064     6159     +4095     
Files with missing lines Coverage Δ
pymc/distributions/mixture.py 33.61% <100.00%> (-61.37%) ⬇️
pymc/distributions/multivariate.py 50.00% <100.00%> (-7.48%) ⬇️
pymc/gp/cov.py 98.00% <100.00%> (ø)
pymc/gp/util.py 96.47% <100.00%> (+0.04%) ⬆️
pymc/initial_point.py 100.00% <100.00%> (ø)
pymc/logprob/rewriting.py 93.47% <100.00%> (+3.36%) ⬆️
pymc/model/core.py 64.97% <100.00%> (-26.78%) ⬇️
pymc/model/fgraph.py 25.25% <100.00%> (-71.65%) ⬇️
pymc/model/transform/conditioning.py 17.20% <100.00%> (-78.49%) ⬇️
pymc/logprob/censoring.py 63.52% <75.00%> (-35.35%) ⬇️
... and 14 more

... and 38 files with indirect coverage changes

@ricardoV94 ricardoV94 force-pushed the fix_custom_dist_inplace branch 3 times, most recently from 422e4b9 to d5a0bb3 Compare October 27, 2023 18:15
@ricardoV94 ricardoV94 force-pushed the fix_custom_dist_inplace branch from d5a0bb3 to e4a6145 Compare November 3, 2023 15:10
@ricardoV94
Copy link
Member Author

Closing in favor of #7491

@ricardoV94 ricardoV94 closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relationship between valued RVs lost during logp inference

1 participant