Skip to content

Clean up marimo progress bar#8184

Open
fonnesbeck wants to merge 3 commits intopymc-devs:mainfrom
fonnesbeck:progbar_typo
Open

Clean up marimo progress bar#8184
fonnesbeck wants to merge 3 commits intopymc-devs:mainfrom
fonnesbeck:progbar_typo

Conversation

@fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Mar 10, 2026

Description

Fix progbar typo: extra "s" was being added to "draws"

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@read-the-docs-community
Copy link

read-the-docs-community bot commented Mar 10, 2026

Documentation build overview

📚 pymc | 🛠️ Build #31764733 | 📁 Comparing 0c37e55 against latest (f89e6c8)


🔍 Preview build

Show files changed (1 files in total): 📝 1 modified | ➕ 0 added | ➖ 0 deleted
File Status
glossary.html 📝 modified

@jessegrabowski
Copy link
Member

I think the actual problem is that the code assumes self.step_name will be singular, but here it is defined as plural. What if we just remove the s there?

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.49%. Comparing base (f89e6c8) to head (0c37e55).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8184   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         124      124           
  Lines       19868    19868           
=======================================
  Hits        18179    18179           
  Misses       1689     1689           
Files with missing lines Coverage Δ
pymc/progress_bar/progress.py 97.29% <100.00%> (-0.04%) ⬇️
pymc/progress_bar/rich_progress.py 98.90% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fonnesbeck
Copy link
Member Author

@jessegrabowski as long as we are comfortable with the header in the sampler stats table using "draw" instead of "draws" as well.

@fonnesbeck fonnesbeck requested a review from ricardoV94 March 10, 2026 14:26
@jessegrabowski
Copy link
Member

@jessegrabowski as long as we are comfortable with the header in the sampler stats table using "draw" instead of "draws" as well.

We could have a standard for that as well? step_name stores the stem, so we add +ing for the name, +s when needed, or whatever else?

@ricardoV94
Copy link
Member

ricardoV94 commented Mar 10, 2026

tuneing and tunes? I think it's too cute.

If there's a need for two names, just specify the two? We have just two cases now anyway (mcmc/smc) so not any meaningful amount of work

@fonnesbeck
Copy link
Member Author

fonnesbeck commented Mar 10, 2026

I think "draw" and "stage" are currently the only values used for action. Is there anything other than MCMC and SMC that uses this particular progbar?

@ricardoV94
Copy link
Member

I think "draw" and "stage" are currently the only values used for action. Is there anything other than MCMC and SMC that uses this particular progbar?

No

@fonnesbeck fonnesbeck changed the title Removed extra "s" from draws in progress bar Clean up marimo progress bar Mar 11, 2026
@fonnesbeck
Copy link
Member Author

Shape errors in DEMetropolis can't be related to these changes.

@ricardoV94
Copy link
Member

Have to cherry pick some patches from main to v6, give me a sec

@ricardoV94
Copy link
Member

@fonnesbeck do you want this to go to main for a patch-release? If so change the target of the branch

@fonnesbeck
Copy link
Member Author

Probably should, yes.

@ricardoV94 ricardoV94 changed the base branch from v6 to main March 11, 2026 14:55
@ricardoV94
Copy link
Member

@fonnesbeck I changed the branch and rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants