Conversation
|
I think the actual problem is that the code assumes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8184 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 124 124
Lines 19868 19868
=======================================
Hits 18179 18179
Misses 1689 1689
🚀 New features to boost your workflow:
|
|
@jessegrabowski as long as we are comfortable with the header in the sampler stats table using "draw" instead of "draws" as well. |
We could have a standard for that as well? step_name stores the stem, so we add +ing for the name, +s when needed, or whatever else? |
|
If there's a need for two names, just specify the two? We have just two cases now anyway (mcmc/smc) so not any meaningful amount of work |
|
I think "draw" and "stage" are currently the only values used for |
No |
|
Shape errors in DEMetropolis can't be related to these changes. |
|
Have to cherry pick some patches from main to v6, give me a sec |
|
@fonnesbeck do you want this to go to main for a patch-release? If so change the target of the branch |
|
Probably should, yes. |
1398f58 to
0c37e55
Compare
|
@fonnesbeck I changed the branch and rebased |
Description
Fix progbar typo: extra "s" was being added to "draws"
Checklist
Type of change