Remove os.path in configdefaults.py

Author: Armavica

pytensor/configdefaults.py

@@ -6,6 +6,7 @@
 import socket
 import sys
 import textwrap
+from pathlib import Path
 
 import numpy as np
 from setuptools._distutils.spawn import find_executable
@@ -33,64 +34,60 @@
 _logger = logging.getLogger("pytensor.configdefaults")
 
 
-def get_cuda_root():
+def get_cuda_root() -> Path | None:
     # We look for the cuda path since we need headers from there
-    v = os.getenv("CUDA_ROOT", "")
-    if v:
-        return v
-    v = os.getenv("CUDA_PATH", "")
-    if v:
-        return v
-    s = os.getenv("PATH")
-    if not s:
-        return ""
-    for dir in s.split(os.path.pathsep):
-        if os.path.exists(os.path.join(dir, "nvcc")):
-            return os.path.dirname(os.path.abspath(dir))
-    return ""
-
-
-def default_cuda_include():
+    if (v := os.getenv("CUDA_ROOT")) is not None:
+        return Path(v)
+    if (v := os.getenv("CUDA_PATH")) is not None:
+        return Path(v)
+    if (s := os.getenv("PATH")) is None:
+        return Path()
+    for dir in s.split(os.pathsep):
+        if (Path(dir) / "nvcc").exists():
+            return Path(dir).absolute().parent
+    return None
+
+
+def default_cuda_include() -> Path | None:
     if config.cuda__root:
-        return os.path.join(config.cuda__root, "include")
-    return ""
+        return Path(config.cuda__root) / "include"
+    return None
 
 
-def default_dnn_base_path():
+def default_dnn_base_path() -> Path | None:
     # We want to default to the cuda root if cudnn is installed there
-    root = config.cuda__root
+    root = Path(config.cuda__root)
     # The include doesn't change location between OS.
-    if root and os.path.exists(os.path.join(root, "include", "cudnn.h")):
+    if (root / "include/cudnn.h").exists():
         return root
-    return ""
+    return None
 
 
-def default_dnn_inc_path():
+def default_dnn_inc_path() -> Path | None:
     if config.dnn__base_path != "":
-        return os.path.join(config.dnn__base_path, "include")
-    return ""
+        return Path(config.dnn__base_path) / "include"
+    return None
 
 
-def default_dnn_lib_path():
+def default_dnn_lib_path() -> Path | None:
     if config.dnn__base_path != "":
         if sys.platform == "win32":
-            path = os.path.join(config.dnn__base_path, "lib", "x64")
+            path = Path(config.dnn__base__path) / "lib/x64"
         elif sys.platform == "darwin":
-            path = os.path.join(config.dnn__base_path, "lib")
+            path = Path(config.dnn__base__path) / "lib"
         else:
             # This is linux
-            path = os.path.join(config.dnn__base_path, "lib64")
+            path = Path(config.dnn__base__path) / "lib64"
         return path
-    return ""
+    return None
 
 
-def default_dnn_bin_path():
+def default_dnn_bin_path() -> Path | None:
     if config.dnn__base_path != "":
         if sys.platform == "win32":
-            return os.path.join(config.dnn__base_path, "bin")
-        else:
-            return config.dnn__library_path
-    return ""
+            return Path(config.dnn__base_path) / "bin"
+        return Path(config.dnn__library_path)
+    return None
 
 
 def _filter_mode(val):
@@ -405,15 +402,11 @@ def add_compile_configvars():
     # Anaconda on Windows has mingw-w64 packages including GCC, but it may not be on PATH.
     if rc != 0:
         if sys.platform == "win32":
-            mingw_w64_gcc = os.path.join(
-                os.path.dirname(sys.executable), "Library", "mingw-w64", "bin", "g++"
-            )
+            mingw_w64_gcc = Path(sys.executable).parent / "Library/mingw-w64/bin/g++"
             try:
                 rc = call_subprocess_Popen([mingw_w64_gcc, "-v"])
                 if rc == 0:
-                    maybe_add_to_os_environ_pathlist(
-                        "PATH", os.path.dirname(mingw_w64_gcc)
-                    )
+                    maybe_add_to_os_environ_pathlist("PATH", mingw_w64_gcc.parent)
             except OSError:
                 rc = 1
             if rc != 0:
@@ -1221,27 +1214,27 @@ def add_numba_configvars():
     )
 
 
-def _default_compiledirname():
+def _default_compiledirname() -> str:
     formatted = config.compiledir_format % _compiledir_format_dict
     safe = re.sub(r"[\(\)\s,]+", "_", formatted)
     return safe
 
 
-def _filter_base_compiledir(path):
+def _filter_base_compiledir(path: Path) -> Path:
     # Expand '~' in path
-    return os.path.expanduser(str(path))
+    return path.expanduser()
 
 
-def _filter_compiledir(path):
+def _filter_compiledir(path: Path) -> Path:
     # Expand '~' in path
-    path = os.path.expanduser(path)
+    path = path.expanduser()
     # Turn path into the 'real' path. This ensures that:
     #   1. There is no relative path, which would fail e.g. when trying to
     #      import modules from the compile dir.
     #   2. The path is stable w.r.t. e.g. symlinks (which makes it easier
     #      to re-use compiled modules).
-    path = os.path.realpath(path)
-    if os.access(path, os.F_OK):  # Do it exist?
+    path = path.resolve()
+    if path.exists():  # Does it exist?
         if not os.access(path, os.R_OK | os.W_OK | os.X_OK):
             # If it exist we need read, write and listing access
             raise ValueError(
@@ -1250,7 +1243,9 @@ def _filter_compiledir(path):
             )
     else:
         try:
-            os.makedirs(path, 0o770)  # read-write-execute for user and group
+            path.mkdir(
+                mode=0o770, parents=True
+            )  # read-write-execute for user and group
         except OSError as e:
             # Maybe another parallel execution of pytensor was trying to create
             # the same directory at the same time.
@@ -1264,36 +1259,38 @@ def _filter_compiledir(path):
     # os.system('touch') returned -1 for an unknown reason; the
     # alternate approach here worked in all cases... it was weird.
     # No error should happen as we checked the permissions.
-    init_file = os.path.join(path, "__init__.py")
-    if not os.path.exists(init_file):
+    init_file = path / "__init__.py"
+    if not init_file.exists():
         try:
             with open(init_file, "w"):
                 pass
         except OSError as e:
-            if os.path.exists(init_file):
+            if init_file.exists():
                 pass  # has already been created
             else:
-                e.args += (f"{path} exist? {os.path.exists(path)}",)
+                e.args += (f"{path} exist? {path.exists()}",)
                 raise
     return path
 
 
-def _get_home_dir():
+def _get_home_dir() -> Path:
     """
     Return location of the user's home directory.
 
     """
-    home = os.getenv("HOME")
-    if home is None:
-        # This expanduser usually works on Windows (see discussion on
-        # theano-users, July 13 2010).
-        home = os.path.expanduser("~")
-        if home == "~":
-            # This might happen when expanduser fails. Although the cause of
-            # failure is a mystery, it has been seen on some Windows system.
-            home = os.getenv("USERPROFILE")
-    assert home is not None
-    return home
+    if (env_home := os.getenv("HOME")) is not None:
+        return Path(env_home)
+
+    # This usually works on Windows (see discussion on theano-users, July 13 2010).
+    path_home = Path.home()
+    if str(path_home) != "~":
+        return path_home
+
+    # This might happen when expanduser fails. Although the cause of
+    # failure is a mystery, it has been seen on some Windows system.
+    windowsfail_home = os.getenv("USERPROFILE")
+    assert windowsfail_home is not None
+    return Path(windowsfail_home)
 
 
 _compiledir_format_dict = {
@@ -1309,8 +1306,8 @@ def _get_home_dir():
 }
 
 
-def _default_compiledir():
-    return os.path.join(config.base_compiledir, _default_compiledirname())
+def _default_compiledir() -> Path:
+    return Path(config.base_compiledir) / _default_compiledirname()
 
 
 def add_caching_dir_configvars():
@@ -1343,9 +1340,9 @@ def add_caching_dir_configvars():
     # part of the roaming part of the user profile. Instead we use the local part
     # of the user profile, when available.
     if sys.platform == "win32" and os.getenv("LOCALAPPDATA") is not None:
-        default_base_compiledir = os.path.join(os.getenv("LOCALAPPDATA"), "PyTensor")
+        default_base_compiledir = Path(os.getenv("LOCALAPPDATA")) / "PyTensor"
     else:
-        default_base_compiledir = os.path.join(_get_home_dir(), ".pytensor")
+        default_base_compiledir = _get_home_dir() / ".pytensor"
 
     config.add(
         "base_compiledir",