Enable the ruff rule ensuring explicit strictness for zips

Author: Armavica

pyproject.toml

@@ -125,8 +125,12 @@ line-length = 88
 exclude = ["doc/", "pytensor/_version.py"]
 
 [tool.ruff.lint]
-select = ["C", "E", "F", "I", "UP", "W", "RUF", "PERF", "PTH", "ISC"]
+select = ["B905", "C", "E", "F", "I", "UP", "W", "RUF", "PERF", "PTH", "ISC"]
 ignore = ["C408", "C901", "E501", "E741", "RUF012", "PERF203", "ISC001"]
+unfixable = [
+    # zip-strict: the auto-fix adds `strict=False` but we might want `strict=True` instead
+    "B905",
+]
 
 
 [tool.ruff.lint.isort]

pytensor/link/c/op.py

@@ -352,7 +352,7 @@ def load_c_code(self, func_files: Iterable[Path]) -> None:
                 "be used at the same time."
             )
 
-        for func_file, code in zip(func_files, self.func_codes):
+        for func_file, code in zip(func_files, self.func_codes, strict=True):
             if self.backward_re.search(code):
                 # This is backward compat code that will go away in a while
 

pytensor/link/pytorch/dispatch/shape.py

@@ -34,7 +34,7 @@ def shape_i(x):
 def pytorch_funcify_SpecifyShape(op, node, **kwargs):
     def specifyshape(x, *shape):
         assert x.ndim == len(shape)
-        for actual, expected in zip(x.shape, shape):
+        for actual, expected in zip(x.shape, shape, strict=True):
             if expected is None:
                 continue
             if actual != expected:

pytensor/tensor/pad.py

@@ -263,7 +263,9 @@ def _linear_ramp_pad(
                 dtype=padded.dtype,
                 axis=axis,
             )
-            for end_value, edge, width in zip(end_value_pair, edge_pair, width_pair)
+            for end_value, edge, width in zip(
+                end_value_pair, edge_pair, width_pair, strict=True
+            )
         )
 
         # Reverse the direction of the ramp for the "right" side

pytensor/tensor/rewriting/ofg.py

@@ -18,7 +18,9 @@ def inline_ofg_expansion(fgraph, node):
     if not op.is_inline:
         return False
 
-    new_out = clone_replace(op.inner_outputs, dict(zip(op.inner_inputs, node.inputs)))
+    new_out = clone_replace(
+        op.inner_outputs, dict(zip(op.inner_inputs, node.inputs, strict=True))
+    )
     copy_stack_trace(op.inner_outputs, new_out)
 
     return new_out
@@ -62,7 +64,9 @@ def late_inline_OpFromGraph(fgraph, node):
 
     """
     op = node.op
-    new_out = clone_replace(op.inner_outputs, dict(zip(op.inner_inputs, node.inputs)))
+    new_out = clone_replace(
+        op.inner_outputs, dict(zip(op.inner_inputs, node.inputs, strict=True))
+    )
     copy_stack_trace(op.inner_outputs, new_out)
 
     return new_out