Make all inplace rewrites happen at 50.x

Author: ricardoV94

pytensor/scan/rewriting.py

@@ -2492,7 +2492,7 @@ def scan_push_out_dot1(fgraph, node):
     "fast_run",
     "inplace",
     "scan",
-    position=75,
+    position=50.5,
 )
 
 scan_eqopt1.register("all_pushout_opt", scan_seqopt1, "fast_run", "scan")

pytensor/sparse/rewriting.py

@@ -210,7 +210,7 @@ def local_inplace_addsd_ccode(fgraph, node):
     ),
     "fast_run",
     "inplace",
-    position=60,
+    position=50.1,
 )
 
 
@@ -239,9 +239,9 @@ def local_addsd_ccode(fgraph, node):
 pytensor.compile.optdb.register(
     "local_addsd_ccode",
     WalkingGraphRewriter(local_addsd_ccode),
-    # Must be after local_inplace_addsd_ccode at 60
+    # Must be after local_inplace_addsd_ccode at 70.0
     "fast_run",
-    position=61,
+    position=70.1,
 )
 
 

pytensor/tensor/random/rewriting/basic.py

@@ -60,7 +60,7 @@ def random_make_inplace(fgraph, node):
     in2out(random_make_inplace, ignore_newtrees=True),
     "fast_run",
     "inplace",
-    position=99,
+    position=50.9,
 )
 
 

pytensor/tensor/rewriting/blas.py

@@ -762,8 +762,6 @@ def local_dot22_to_ger_or_gemv(fgraph, node):
 )
 
 
-# After destroyhandler(49.5) but before we try to make elemwise things
-# inplace (75)
 blas_opt_inplace = in2out(
     local_inplace_gemm, local_inplace_gemv, local_inplace_ger, name="blas_opt_inplace"
 )
@@ -773,7 +771,8 @@ def local_dot22_to_ger_or_gemv(fgraph, node):
     "fast_run",
     "inplace",
     "blas_opt_inplace",
-    position=70.0,
+    # Before we try to make elemwise things inplace (70.5)
+    position=50.2,
 )
 
 

pytensor/tensor/rewriting/blas_scipy.py

@@ -33,5 +33,5 @@ def make_ger_destructive(fgraph, node):
         make_scipy_blas_destructive,
         "fast_run",
         "inplace",
-        position=70.0,
+        position=50.2,
     )

pytensor/tensor/rewriting/elemwise.py

@@ -186,9 +186,8 @@ def apply(self, fgraph):
                     for i in range(len(node.inputs))
                     if i not in baseline.values()
                     and not isinstance(node.inputs[i], Constant)
-                    and
                     # the next line should not be costly most of the time.
-                    not fgraph.has_destroyers([node.inputs[i]])
+                    and not fgraph.has_destroyers([node.inputs[i]])
                     and node.inputs[i] not in protected_inputs
                 ]
             else:
@@ -362,7 +361,7 @@ def print_summary(self, stream=sys.stdout, level=0, depth=-1):
     "inplace_elemwise_optimizer",
     "fast_run",
     "inplace",
-    position=75,
+    position=50.5,
 )
 
 

pytensor/tensor/rewriting/subtensor.py

@@ -1307,7 +1307,7 @@ def local_inplace_setsubtensor(fgraph, node):
     ),
     "fast_run",
     "inplace",
-    position=60,
+    position=50.1,
 )
 
 
@@ -1329,7 +1329,7 @@ def local_inplace_AdvancedIncSubtensor1(fgraph, node):
     ),
     "fast_run",
     "inplace",
-    position=60,
+    position=70.6,
 )
 
 
@@ -1355,7 +1355,7 @@ def local_inplace_AdvancedIncSubtensor(fgraph, node):
     ),
     "fast_run",
     "inplace",
-    position=60,
+    position=70.6,
 )
 
 

pytensor/typed_list/rewriting.py

@@ -22,5 +22,5 @@ def typed_list_inplace_rewrite(fgraph, node):
     ),
     "fast_run",
     "inplace",
-    position=60,
+    position=50.1,
 )