Raise explicitly on Python methods that are incompatible with lazy variables

ricardoV94 · ricardoV94 · commit fb92728fda3e · 2025-02-12T15:50:37.000+01:00
Notably changes the behavior of `__bool__` to always raise. Before there was a hack based on whether a variable had been compared to something before.
diff --git a/pytensor/compile/function/pfunc.py b/pytensor/compile/function/pfunc.py
@@ -569,7 +569,7 @@ def construct_pfunc_ins_and_outs(
     if not fgraph:
         # Extend the outputs with the updates on input variables so they are
         # also cloned
-        additional_outputs = [i.update for i in inputs if i.update]
+        additional_outputs = [i.update for i in inputs if i.update is not None]
         if outputs is None:
             out_list = []
         else:
@@ -608,7 +608,7 @@ def construct_pfunc_ins_and_outs(
             new_i.variable = iv
 
             # If needed, replace the input's update by its cloned equivalent
-            if i.update:
+            if i.update is not None:
                 new_i.update = clone_d[i.update]
 
             new_inputs.append(new_i)
diff --git a/pytensor/compile/function/types.py b/pytensor/compile/function/types.py
@@ -198,7 +198,7 @@ def std_fgraph(
     update_mapping = {}
     out_idx = len(output_specs)
     for idx, input_spec in enumerate(input_specs):
-        if input_spec.update:
+        if input_spec.update is not None:
             updates.append(input_spec.update)
             update_mapping[out_idx] = idx
             out_idx += 1
@@ -1195,7 +1195,7 @@ def insert_deepcopy(fgraph, wrapped_inputs, wrapped_outputs):
     updated_fgraph_inputs = {
         fgraph_i
         for i, fgraph_i in zip(wrapped_inputs, fgraph.inputs, strict=True)
-        if getattr(i, "update", False)
+        if getattr(i, "update", None) is not None
     }
 
     # We can't use fgraph.inputs as this don't include Constant Value.
@@ -1351,7 +1351,11 @@ def check_unused_inputs(inputs, outputs, on_unused_input):
             ancestors(
                 (
                     [o.variable for o in outputs]
-                    + [i.update for i in inputs if getattr(i, "update", False)]
+                    + [
+                        i.update
+                        for i in inputs
+                        if getattr(i, "update", None) is not None
+                    ]
                 ),
                 blockers=[i.variable for i in inputs],
             )
diff --git a/pytensor/compile/nanguardmode.py b/pytensor/compile/nanguardmode.py
@@ -36,7 +36,7 @@ def _is_numeric_value(arr, var):
         return False
     elif isinstance(arr, np.random.mtrand.RandomState | np.random.Generator):
         return False
-    elif var and isinstance(var.type, RandomType):
+    elif var is not None and isinstance(var.type, RandomType):
         return False
     elif isinstance(arr, slice):
         return False
diff --git a/pytensor/scalar/basic.py b/pytensor/scalar/basic.py
@@ -725,6 +725,37 @@ def get_scalar_type(dtype, cache: dict[str, ScalarType] = {}) -> ScalarType:
 
 
 class _scalar_py_operators:
+    # These can't work because Python requires native output types
+    def __bool__(self):
+        raise TypeError(
+            "ScalarVariable cannot be converted to Python boolean. "
+            "Call `.astype(bool)` for the symbolic equivalent."
+        )
+
+    def __index__(self):
+        raise TypeError(
+            "ScalarVariable cannot be converted to Python integer. "
+            "Call `.astype(int)` for the symbolic equivalent."
+        )
+
+    def __int__(self):
+        raise TypeError(
+            "ScalarVariable cannot be converted to Python integer. "
+            "Call `.astype(int)` for the symbolic equivalent."
+        )
+
+    def __float__(self):
+        raise TypeError(
+            "ScalarVariable cannot be converted to Python float. "
+            "Call `.astype(float)` for the symbolic equivalent."
+        )
+
+    def __complex__(self):
+        raise TypeError(
+            "ScalarVariable cannot be converted to Python complex number. "
+            "Call `.astype(complex)` for the symbolic equivalent."
+        )
+
     # So that we can simplify checking code when we have a mixture of ScalarType
     # variables and Tensor variables
     ndim = 0
diff --git a/pytensor/scalar/loop.py b/pytensor/scalar/loop.py
@@ -60,12 +60,12 @@ def __init__(
             constant = []
         if not len(init) == len(update):
             raise ValueError("An update must be given for each init variable")
-        if until:
+        if until is not None:
             inputs, outputs = clone([*init, *constant], [*update, until])
         else:
             inputs, outputs = clone([*init, *constant], update)
 
-        self.is_while = bool(until)
+        self.is_while = until is not None
         self.inputs, self.outputs = self._cleanup_graph(inputs, outputs)
         self._validate_updates(self.inputs, self.outputs)
 
diff --git a/pytensor/scalar/math.py b/pytensor/scalar/math.py
@@ -942,7 +942,7 @@ def inner_loop_a(sum_a, delta, xpow, k_minus_one_minus_n, fac, dfac, x):
             dfac = k_minus_one_minus_n * dfac + fac
             fac *= k_minus_one_minus_n
             delta = dfac / xpow
-            return (sum_a, delta, xpow, k_minus_one_minus_n, fac, dfac), ()
+            return (sum_a, delta, xpow, k_minus_one_minus_n, fac, dfac), None
 
         init = [sum_a0, delta, xpow, k_minus_one_minus_n, fac, dfac]
         constant = [x]
diff --git a/pytensor/scan/basic.py b/pytensor/scan/basic.py
@@ -979,7 +979,7 @@ def wrap_into_list(x):
         # user-specified within the inner-function (e.g. by returning an update
         # `dict`) or the `SharedVariable.default_update`s of a shared variable
         # created in the inner-function.
-        if input.update and (is_local or input.variable in updates):
+        if input.update is not None and (is_local or input.variable in updates):
             # We need to remove the `default_update`s on the shared
             # variables created within the context of the loop function
             # (e.g. via use of `RandomStream`); otherwise, they'll get
diff --git a/pytensor/scan/op.py b/pytensor/scan/op.py
@@ -2582,7 +2582,7 @@ def compute_all_gradients(known_grads):
 
         # mask inputs that get no gradients
         for dx in range(len(dC_dinps_t)):
-            if not dC_dinps_t[dx]:
+            if dC_dinps_t[dx] is None:
                 dC_dinps_t[dx] = pt.zeros_like(diff_inputs[dx])
             else:
                 disconnected_dC_dinps_t[dx] = False
diff --git a/pytensor/tensor/basic.py b/pytensor/tensor/basic.py
@@ -3386,7 +3386,14 @@ def __getitem__(self, *args):
                 raise NotImplementedError(
                     "Not implemented for slices whose step is complex"
                 )
-        ranges = [arange(sl.start or 0, sl.stop, sl.step or 1) for sl in args[0]]
+        ranges = [
+            arange(
+                sl.start if sl.start is not None else 0,
+                sl.stop,
+                sl.step if sl.step is not None else 1,
+            )
+            for sl in args[0]
+        ]
         shapes = [
             tuple([1] * j + [r.shape[0]] + [1] * (ndim - 1 - j))
             for j, r in enumerate(ranges)
diff --git a/pytensor/tensor/conv/abstract_conv.py b/pytensor/tensor/conv/abstract_conv.py
@@ -2198,7 +2198,7 @@ def __init__(
         ):
             border_mode = "valid"
 
-        self.imshp = tuple(imshp) if imshp else (None,) * (2 + convdim)
+        self.imshp = tuple(imshp) if imshp is not None else (None,) * (2 + convdim)
         for imshp_i in self.imshp:
             if imshp_i is not None:
                 # Components of imshp should be constant or ints
@@ -2208,7 +2208,7 @@ def __init__(
                     raise ValueError(
                         "imshp should be None or a tuple of constant int values"
                     ).with_traceback(sys.exc_info()[2])
-        if kshp:
+        if kshp is not None:
             self.kshp = tuple(kshp)
         else:
             self.kshp = (None,) * ((2 + 2 * convdim) if unshared else (2 + convdim))
diff --git a/pytensor/tensor/math.py b/pytensor/tensor/math.py
@@ -1797,14 +1797,14 @@ def R_op(self, inputs, eval_points):
         if eval_points[0] is None and eval_points[1] is None:
             return [None]
 
-        if eval_points[0]:
+        if eval_points[0] is not None:
             t1 = self(eval_points[0], inputs[1])
-        if eval_points[1]:
+        if eval_points[1] is not None:
             t2 = self(inputs[0], eval_points[1])
 
-        if eval_points[0] and eval_points[1]:
+        if eval_points[0] is not None and eval_points[1] is not None:
             return [t1 + t2]
-        elif eval_points[0]:
+        elif eval_points[0] is not None:
             return [t1]
         else:
             return [t2]
diff --git a/pytensor/tensor/rewriting/blas.py b/pytensor/tensor/rewriting/blas.py
@@ -803,7 +803,7 @@ def local_dot22_to_dot22scalar(fgraph, node):
     """
     if node.op != mul:
         return False
-    i_dot22 = [x.owner and x.owner.op == _dot22 for x in node.inputs]
+    i_dot22 = [x.owner is not None and x.owner.op == _dot22 for x in node.inputs]
     if not any(i_dot22):
         return False  # no dot22
     if i_dot22.count(True) > 1:
@@ -813,14 +813,16 @@ def local_dot22_to_dot22scalar(fgraph, node):
     dot22_idx = i_dot22.index(True)
     d = node.inputs[dot22_idx]
     i_scalar = [_as_scalar(x, dtype=d.dtype) for x in node.inputs]
-    if not any(i_scalar):
+    if all(i is None for i in i_scalar):
         # Check if we can reorder the graph as this mul have a mul in inputs.
         # We support only 1 additional level of mul.
         # The canonizer should have merged those mul together.
         i_mul = [
             x.owner
             and x.owner.op == mul
-            and any(_as_scalar(x_i, dtype=d.dtype) for x_i in x.owner.inputs)
+            and any(
+                _as_scalar(x_i, dtype=d.dtype) is not None for x_i in x.owner.inputs
+            )
             for x in node.inputs
         ]
         if not any(i_mul):
@@ -834,7 +836,7 @@ def local_dot22_to_dot22scalar(fgraph, node):
 
         scalar_idx = -1
         for i, x in enumerate(m.owner.inputs):
-            if _as_scalar(x, dtype=d.dtype) and (
+            if _as_scalar(x, dtype=d.dtype) is not None and (
                 pytensor.scalar.upcast(x.type.dtype, d.type.dtype) == d.type.dtype
             ):
                 scalar_idx = i
diff --git a/pytensor/tensor/rewriting/math.py b/pytensor/tensor/rewriting/math.py
@@ -1331,14 +1331,14 @@ def local_sum_prod_of_mul_or_div(fgraph, node):
 
     # If we have a `Prod`, then the outside terms need to be raised to the power of the number of elements
     # that were contracted in the input
-    if isinstance(node.op, Prod) and inner_term:
+    if isinstance(node.op, Prod) and inner_term is not None:
         dtype = inner_term.dtype
         n_reduced_elements = prod(
             [inner_term.shape[i].astype(dtype) for i in reduced_axes]
         )
         outer_term = outer_term**n_reduced_elements
 
-    if not inner_term:
+    if inner_term is None:
         # Sum/Prod is useless, just return the outer_term
         # (This can only happen for mul, not division)
         new_out = outer_term
@@ -1992,7 +1992,7 @@ def local_pow_canonicalize(fgraph, node):
         # x ** 1 = x
         new_out = broadcast_arrays(*node.inputs)[0]
 
-    if not new_out:
+    if new_out is None:
         return
 
     if new_out.dtype != node.out.dtype:
@@ -2119,7 +2119,7 @@ def local_pow_to_nested_squaring(fgraph, node):
             rval1_scal = None
             while y_to_do > 0:
                 log_to_do = int(np.log2(y_to_do))
-                if rval1:
+                if rval1 is not None:
                     rval1 *= pow2[log_to_do]
                     rval1_scal *= pow2_scal[log_to_do]
                 else:
@@ -2137,7 +2137,7 @@ def local_pow_to_nested_squaring(fgraph, node):
                 rval = [reciprocal(rval1)]
             else:
                 rval = [rval1]
-        if rval:
+        if rval is not None:
             rval[0] = cast(rval[0], odtype)
             return rval
 
diff --git a/pytensor/tensor/rewriting/special.py b/pytensor/tensor/rewriting/special.py
@@ -162,7 +162,7 @@ def softmax_simplifier(numerators, denominators):
                         matching_denom = denominator
                         break
 
-        if matching_denom:
+        if matching_denom is not None:
             softmax = Softmax(axis=sum_axis)(numerator.owner.inputs[0])
             copy_stack_trace(numerator, softmax)
             numerators.remove(numerator)
diff --git a/pytensor/tensor/variable.py b/pytensor/tensor/variable.py
@@ -26,53 +26,54 @@
 
 
 class _tensor_py_operators:
+    # These can't work because Python requires native output types
+    def __bool__(self):
+        raise TypeError(
+            "TensorVariable cannot be converted to Python boolean. "
+            "Call `.astype(bool)` for the symbolic equivalent."
+        )
+
+    def __index__(self):
+        raise TypeError(
+            "TensorVariable cannot be converted to Python integer. "
+            "Call `.astype(int)` for the symbolic equivalent."
+        )
+
+    def __int__(self):
+        raise TypeError(
+            "TensorVariable cannot be converted to Python integer. "
+            "Call `.astype(int)` for the symbolic equivalent."
+        )
+
+    def __float__(self):
+        raise TypeError(
+            "TensorVariables cannot be converted to Python float. "
+            "Call `.astype(float)` for the symbolic equivalent."
+        )
+
+    def __complex__(self):
+        raise TypeError(
+            "TensorVariables cannot be converted to Python complex number. "
+            "Call `.astype(complex)` for the symbolic equivalent."
+        )
+
     def __abs__(self):
         return pt.math.abs(self)
 
     def __neg__(self):
         return pt.math.neg(self)
 
-    # These won't work because Python requires an int return value
-    # def __int__(self): return convert_to_int32(self)
-    # def __float__(self): return convert_to_float64(self)
-    # def __complex__(self): return convert_to_complex128(self)
-
-    _is_nonzero = True
-
     def __lt__(self, other):
-        rval = pt.math.lt(self, other)
-        rval._is_nonzero = False
-        return rval
+        return pt.math.lt(self, other)
 
     def __le__(self, other):
-        rval = pt.math.le(self, other)
-        rval._is_nonzero = False
-        return rval
+        return pt.math.le(self, other)
 
     def __gt__(self, other):
-        rval = pt.math.gt(self, other)
-        rval._is_nonzero = False
-        return rval
+        return pt.math.gt(self, other)
 
     def __ge__(self, other):
-        rval = pt.math.ge(self, other)
-        rval._is_nonzero = False
-        return rval
-
-    def __bool__(self):
-        # This is meant to prohibit stuff like a < b < c, which is internally
-        # implemented as (a < b) and (b < c). The trouble with this is the
-        # side-effect that checking for a non-NULL a by typing "if a: ..."
-        # uses the same __nonzero__ method.  We want these both to work, but
-        # it seems impossible.  Currently, all vars evaluate to nonzero except
-        # the return values of comparison operators, which raise this
-        # exception.  If you can think of a better solution, go for it!
-        #
-        # __bool__ is Python 3.x data model. __nonzero__ is Python 2.x.
-        if self._is_nonzero:
-            return True
-        else:
-            raise TypeError("Variables do not support boolean operations.")
+        return pt.math.ge(self, other)
 
     def __invert__(self):
         return pt.math.invert(self)
diff --git a/tests/tensor/test_type.py b/tests/tensor/test_type.py
@@ -399,7 +399,7 @@ def test_tensor_creator_dtype_catch(dtype):
         tensor(dtype, shape=(None,))
 
     # This should work
-    assert tensor(dtype=dtype, shape=(None,))
+    assert tensor(dtype=dtype, shape=(None,)) is not None
 
 
 def test_tensor_creator_ignores_rare_dtype_name():
