Include Op in message when raising NotImplementedError from grad
#1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 188 188
Lines 48506 48506
Branches 8672 8672
=======================================
Hits 39771 39771
Misses 6583 6583
Partials 2152 2152
🚀 New features to boost your workflow:
|
ricardoV94
approved these changes
Mar 24, 2025
|
Thanks @Aarsh-Wankar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an error message
f"grad not implemented for Op {self}"in theNotImplementedErrorfor the grad function ofOpclass.Description
This change helps in finding the Op which has an unimplemented grad when many Ops are strung together.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1314.org.readthedocs.build/en/1314/