Use sparse structured methods where possible #1727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Nov 18, 2025
Comment on lines
203
to
+204
| def transpose(self): | ||
| raise NotImplementedError | ||
| return self.T |
Member
There was a problem hiding this comment.
Do you want to add the mT property as well? Will make code that works with tensors more likely to work with sparse variables as well
ricardoV94
approved these changes
Nov 18, 2025
Member
|
Re: copy is identity function, we can make it return One thing with these Elemwise operations is that they box the sparse part like: In general I'm not a big fan of this eager implementation. I would rather do it as a rewrite: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For elemwise functions that are idempotent at 0 such that f(0) = 0, it is safe to always use a
structured_function, rather than converting back to dense.Such functions are
sinh,tanh,arcsin,arctan,arcsinh,deg2rad,rad2deg,expm1, andlog1p.I also removed the dense_override on
.transpose, which now callsself.T. I think this is fine for now, since we're only supporting sparse matrices, not general sparse arrays. Previously,sparse.Treturned a sparse, butsparse.transposereturned a dense, which is baffling.copyseems like another low-hanging fruit, but I'm leaving it for another time because it was slightly harder to reason about than the functions in this PR.Related Issue
Checklist
Type of change