Hotfix - Fix dimension assertion for adding multidimensional event effects to multidimensional MMM (#1969)

* Fix dimension validation for multidimensional events.
* Add a test for adding multidimensional events to multidimensional.MMM

Author: TeemuSailynoja

pymc_marketing/mmm/multidimensional.py

@@ -490,7 +490,7 @@ def add_events(
             If the event effect dimensions do not contain the prefix and model dimensions.
 
         """
-        if not set(effect.dims).issubset((prefix, self.dims)):
+        if not set(effect.dims).issubset((prefix, *self.dims)):
             raise ValueError(
                 f"Event effect dims {effect.dims} must contain {prefix} and {self.dims}"
             )

tests/mmm/test_multidimensional.py

@@ -813,12 +813,13 @@ def create(
         prefix: str = "holiday",
         sigma_dims: str | None = None,
         effect_size: Prior | None = None,
+        dims: tuple[str] | str | None = None,
     ):
         basis = GaussianBasis()
         return EventEffect(
             basis=basis,
             effect_size=Prior("Normal"),
-            dims=(prefix,),
+            dims=dims or (prefix,),
         )
 
     return create
@@ -882,10 +883,14 @@ def test_mmm_with_events(
     )
     assert len(mmm.mu_effects) == 1
 
+    df_events_with_country = df_events.copy()
+    df_events_with_country["country"] = "A"
     mmm.add_events(
-        df_events,
+        df_events_with_country,
         prefix="another_event_type",
-        effect=create_event_effect(prefix="another_event_type"),
+        effect=create_event_effect(
+            prefix="another_event_type", dims=("country", "another_event_type")
+        ),
     )
     assert len(mmm.mu_effects) == 2