Add FrequencyReachAdditiveEffect
#1968
Draft
+493
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
- Coverage 92.18% 91.12% -1.07%
==========================================
Files 67 69 +2
Lines 8147 8424 +277
==========================================
+ Hits 7510 7676 +166
- Misses 637 748 +111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
williambdean
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Shall we change additive_effect.py into additive_effects/ submodule and has this as a file?
There was a problem hiding this comment.
All can added to __init__ so that the import is kept
There was a problem hiding this comment.
I am happy to move things around, but for me the main question of this PR is:
- Should we somehow modify
SaturationTransformationto offer strong separation between saturation asymptote and lambda, c, slope, etc?
|
Amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Frequency/Reach support via the
MuEffectinterface.Similar, but slightly different (see below) to the implementation described here
Notes:
1) The formulation is not strictly equivalent. Notice that ourfrequency_sat: Tensorvariablealready applies the multiplicativeBetacoefficient. If we want a fully equivalent implementation we need to call , but then we cannot rely on.applyto do dim_handling.Introduced
HillShapeSaturationto make the formulation equivalentThis is a very drafty feature. No support for optimization whatsoever.
Related Issue
Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1968.org.readthedocs.build/en/1968/