-
Notifications
You must be signed in to change notification settings - Fork 335
Clearer explanation of how lift tests are implemented behind the scenes in existing lift test notebook #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+141
−3
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7cc999d
initial stab at describing lift test implementation details
drbenvincent 34b2c8c
text improvements
drbenvincent 38862d0
Add in link to lift test notebook in CausalPy
drbenvincent 4531055
convert admonition to a dropdown (closed by default, I believe)
drbenvincent f74794a
hide-output cell tag for something not related to what I've changed b…
drbenvincent 837015d
Merge branch 'main' into lift-test-clarifications
drbenvincent d01e7a7
Merge branch 'main' into lift-test-clarifications
drbenvincent 26cf2df
add clarification that users do not need to manually scale data
drbenvincent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williambdean , just to confirm. Do we need to scale the lift data? Also, a review from you would be much appreciated :)
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using the multidimensional API already in the notebook, we should not need scaling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi both. I looked at these comments, and what I wrote, and tried to figure out what changes are needed. I think it's all pretty clear that these are internal implementation steps, but I have added a note to say that users do not need to do any scaling. Is that good enough to make this new callout box accurate enough to merge?