Skip to content

Commit 4fe806e

Browse files
committed
Drop support for python 3.7. (#806)
Python 3.7 has been marked "End Of Life", therefore we no longer support it or test it.
1 parent f6fa92d commit 4fe806e

File tree

6 files changed

+9
-23
lines changed

6 files changed

+9
-23
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ jobs:
2020
name: ${{ matrix.task.name }} - ${{ matrix.os.name }} ${{ matrix.python.name }} ${{ matrix.arch.name }}
2121
runs-on: ${{ matrix.os.runs-on }}
2222
container: ${{ matrix.os.container[matrix.python.docker] }}
23-
# present runtime seems to be about 2 minutes
24-
# with pypy being the exception (10 minutes)
23+
# present runtime seems to be about 2-4 minutes
24+
# with pypy being the exception (7 minutes)
2525
timeout-minutes: 15
2626
strategy:
2727
fail-fast: false
@@ -35,7 +35,6 @@ jobs:
3535
runs-on: ubuntu-latest
3636
matrix: linux
3737
container:
38-
3.7: docker://python:3.7-buster
3938
3.8: docker://python:3.8-buster
4039
3.9: docker://python:3.9-buster
4140
3.10: docker://python:3.10-buster
@@ -50,12 +49,6 @@ jobs:
5049
x86: win32
5150
x64: win64
5251
python:
53-
- name: CPython 3.7
54-
tox: py37
55-
action: 3.7
56-
docker: 3.7
57-
matrix: 3.7
58-
implementation: cpython
5952
- name: CPython 3.8
6053
tox: py38
6154
action: 3.8
@@ -74,13 +67,6 @@ jobs:
7467
docker: '3.10'
7568
matrix: '3.10'
7669
implementation: cpython
77-
- name: PyPy 3.7
78-
tox: pypy37
79-
action: pypy-3.7
80-
docker: pypy3.7
81-
matrix: 3.7
82-
implementation: pypy
83-
openssl_msvc_version: 2019
8470
- name: PyPy 3.8
8571
tox: pypy38
8672
action: pypy-3.8

README.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ Supported versions
1919

2020
Version `2.5.3 <https://github.com/riptideio/pymodbus/releases/tag/v2.5.3>`_ is the last 2.x release with support to python2.7.x and is in maintenance mode.
2121

22-
Version `3.0.0dev3 <https://github.com/riptideio/pymodbus/releases/tag/v3.0.0dev3>`_ is the current prerelease of 3.0.0 (Supports only Python >=3.7)
22+
Version `3.0.0dev4 <https://github.com/riptideio/pymodbus/releases/tag/v3.0.0dev3>`_ is the current prerelease of 3.0.0 (Supports only Python >=3.8)
23+
24+
Remark: "Supports only" means that we only test with those versions, lower versions (e.g. 3.7) might work typically depending on the actual setup.
2325

2426
.. important::
2527
**Note 3.0.0 is a major release with a number of incompatible changes.**

doc/INSTALL

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Requirements
22
-------------
33

4-
* Python 3.7 or later.
4+
* Python 3.8 or later.
55
* Python Twisted or Tornado (if not using asyncio for async client and server),
66
remark Twisted and Tornado are in maintenance mode, and might either be dropped or supplied as plugins in the future.
77

pymodbus/server/async_io.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,6 @@ def __init__(self,
476476
# constructors cannot be declared async, so we have to
477477
# defer the initialization of the server
478478
self.server = None
479-
# start_serving is new in version 3.7
480479
self.server_factory = self.loop.create_server(
481480
lambda: self.handler(self),
482481
*self.address,

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
""",
5252
classifiers=[
5353
'Development Status :: 4 - Beta',
54-
"Programming Language :: Python :: 3.7",
5554
"Programming Language :: Python :: 3.8",
5655
"Programming Language :: Python :: 3.9",
5756
"Programming Language :: Python :: 3.10",
@@ -78,7 +77,7 @@
7877
platforms=['Linux', 'Mac OS X', 'Win'],
7978
include_package_data=True,
8079
zip_safe=True,
81-
python_requires='>=3.7',
80+
python_requires='>=3.8',
8281
install_requires=install_requires,
8382
extras_require={
8483
'quality': [
@@ -101,7 +100,7 @@
101100
'tornado': [
102101
'tornado == 4.5.3'
103102
],
104-
'repl:python_version >= "3.7"': [
103+
'repl:python_version >= "3.8"': [
105104
'click>=7.0',
106105
'prompt-toolkit>=3.0.8',
107106
'pygments>=2.2.0',

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
[tox]
77
# pypy38 does not work on windows, due to an internal error.
8-
envlist = py{37,38,39,310,py37,py38}
8+
envlist = py{38,39,310,py38}
99

1010
[testenv]
1111
deps = -r requirements-tests.txt

0 commit comments

Comments
 (0)