Add flake8-noqa plugin. (#891)

Author: janiversen

TODO_add_checks

@@ -6,8 +6,6 @@
     pyflakes
     pydocstyle
     flake8-comprehensions
-    flake8-noqa
-    mccabe
 
 - prettier
 - mypy

doc/api/pydoc/build.py

@@ -81,7 +81,7 @@ def classify_class_attrs(cls):
             kind = "class method"
         elif isinstance(obj, property):
             kind = "property"
-        elif (inspect.ismethod(obj_via_getattr) or # noqa W504
+        elif (inspect.ismethod(obj_via_getattr) or  # noqa: W504
               inspect.ismethoddescriptor(obj_via_getattr)):
             kind = "method"
         else:
@@ -98,7 +98,7 @@ def classify_class_attrs(cls):
 class DefaultFormatter(pydoc.HTMLDoc):
     """Default formatter."""
 
-    def docmodule(self, object, name=None, mod=None, packageContext = None, *ignored):  # noqa C901
+    def docmodule(self, object, name=None, mod=None, packageContext=None, *ignored):  # noqa: C901
         """Produce HTML documentation for a module object."""
         my_name = object.__name__  # ignore the passed-in name
         parts = split(my_name, '.')
@@ -191,7 +191,7 @@ def docmodule(self, object, name=None, mod=None, packageContext = None, *ignored
         if classes:
             # FIX  classlist = map(lambda (key, value): value, classes)
             contents = [
-                self.formattree(inspect.getclasstree(classlist, 1), my_name)]  # noqa F821
+                self.formattree(inspect.getclasstree(classlist, 1), my_name)]  # noqa: F821
             for key, value in classes:
                 contents.append(self.document(value, key, my_name, fdict, cdict))
             result = result + self.bigsection(
@@ -264,7 +264,7 @@ def moduleSection(self, object, packageContext):
                         items.append(
                             self.modpkglink((modname, name, ispackage, isshadowed))
                         )
-                except:  # noqa E722 NOSONAR
+                except:  # noqa: E722 NOSONAR
                     items.append(
                         self.modpkglink((modname, name, ispackage, isshadowed))
                     )
@@ -440,8 +440,8 @@ def clean(self, objectList, object):
             for excludeObject in self.exclusions.values():
                 if hasattr(excludeObject, key) and excludeObject is not object:
                     if (
-                        getattr(excludeObject, key) is value or # noqa W504
-                        (hasattr(excludeObject, '__name__') and # noqa W504
+                        getattr(excludeObject, key) is value or  # noqa: W504
+                        (hasattr(excludeObject, '__name__') and  # noqa: W504
                          excludeObject.__name__ == "Numeric"
                          )
                     ):

doc/api/pydoctor/build.py

@@ -24,5 +24,5 @@
 
     if os.path.exists('../../../build'):
         shutil.move("html", "../../../build/pydoctor")
-except:  # noqa E722 NOSONAR pylint: disable=bare-except
+except:  # noqa: E722 NOSONAR pylint: disable=bare-except
     print("Pydoctor unavailable...not building")

examples/common/modbus_payload.py

@@ -163,10 +163,10 @@ def run_binary_payload_ex():
                                                      wordorder=word_endian)
 
         assert decoder._byteorder == (builder._byteorder,  # nosec pylint: disable=protected-access
-                                      "Make sure byteorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder") # noqa E501
+                                      "Make sure byteorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder")  # noqa: E501
 
         assert decoder._wordorder == (builder._wordorder,  # nosec pylint: disable=protected-access
-                                      "Make sure wordorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder") # noqa E501
+                                      "Make sure wordorder is consistent between BinaryPayloadBuilder and BinaryPayloadDecoder")  # noqa: E501
 
         decoded = OrderedDict([
             ('string', decoder.decode_string(len(my_string))),

examples/common/synchronous_client.py

@@ -147,9 +147,9 @@ def run_sync_client():
     assert not rr.isError()  # nosec test that we are not an error
 
     arguments = {
-        'read_address': 1,  # noqa E221
-        'read_count': 8,  # noqa E221
-        'write_address': 1,  # noqa E221
+        'read_address': 1,
+        'read_count': 8,
+        'write_address': 1,
         'write_registers': [20] * 8,
     }
     log.debug("Read write registers simultaneously")

examples/contrib/asynchronous_asyncio_serial_client.py

@@ -78,9 +78,9 @@ async def start_async_test(client):
     assert rq.function_code < 0x80  # nosec test that we are not an error
 
     arguments = {
-        'read_address': 1,  # noqa E221
-        'read_count': 8,  # noqa E221
-        'write_address': 1,  # noqa E221
+        'read_address': 1,
+        'read_count': 8,
+        'write_address': 1,
         'write_registers': [20] * 8,
     }
     rq = await client.readwrite_registers(unit=UNIT, **arguments)

examples/contrib/concurrent_client.py

@@ -65,7 +65,7 @@ def create(cls, in_process=False):
 # We use named tuples here as they are very lightweight while giving us
 # all the benefits of classes.
 # -------------------------------------------------------------------------- #
-WorkRequest = namedtuple('WorkRequest', 'request, work_id')  # noqa 241
+WorkRequest = namedtuple('WorkRequest', 'request, work_id')
 WorkResponse = namedtuple('WorkResponse', 'is_exception, work_id, response')
 
 

examples/contrib/libmodbus_client.py

@@ -163,9 +163,9 @@ def create_rtu_client(cls, **kwargs):
         :param baudrate: The baud rate to use for the serial device
         :returns: A new level1 client
         """
-        my_port = kwargs.get('port', '/dev/ttyS0')  # noqa E221
+        my_port = kwargs.get('port', '/dev/ttyS0')
         baudrate = kwargs.get('baud', Defaults.Baudrate)
-        parity = kwargs.get('parity', Defaults.Parity)  # noqa E221
+        parity = kwargs.get('parity', Defaults.Parity)
         bytesize = kwargs.get('bytesize', Defaults.Bytesize)
         stopbits = kwargs.get('stopbits', Defaults.Stopbits)
         my_client = LIB.modbus_new_rtu(my_port, baudrate, parity, bytesize, stopbits)

examples/contrib/message_generator.py

@@ -257,10 +257,10 @@ def main():
             print("Logging is not supported on this system")
 
     framer = {
-        'tcp': ModbusSocketFramer,  # noqa E221
-        'rtu': ModbusRtuFramer,  # noqa E221
+        'tcp': ModbusSocketFramer,
+        'rtu': ModbusRtuFramer,
         'binary': ModbusBinaryFramer,
-        'ascii': ModbusAsciiFramer,  # noqa E221
+        'ascii': ModbusAsciiFramer,
     }.get(option.framer, ModbusSocketFramer)(None)
 
     generate_messages(framer, option)

examples/contrib/message_parser.py

@@ -195,10 +195,10 @@ def main():
             print(f"Logging is not supported on this system- {exc}")
 
     framer = {
-        'tcp': ModbusSocketFramer,  # noqa E221
-        'rtu': ModbusRtuFramer,  # noqa E221
+        'tcp': ModbusSocketFramer,
+        'rtu': ModbusRtuFramer,
         'binary': ModbusBinaryFramer,
-        'ascii': ModbusAsciiFramer,  # noqa E221
+        'ascii': ModbusAsciiFramer,
     }.get(option.framer or option.parser, ModbusSocketFramer)
 
     decoder = Decoder(framer, option.ascii)