Setup black. (#895)

Author: janiversen

.github/workflows/ci.yml

@@ -192,6 +192,9 @@ jobs:
           - name: flake8
             tox: flake8
             # continue_on_error: true
+          - name: black
+            tox: black
+            # continue_on_error: true
           - name: Docs
             tox: docs
         os:

pymodbus/__init__.py

@@ -12,6 +12,7 @@
 import logging as __logging
 from logging import NullHandler as __null
 import pymodbus.version as __version
+
 __version__ = __version.version.short()
 __author__ = "Galen Collins"
 __maintainer__ = "dhoomakethu"

pymodbus/bit_read_message.py

@@ -146,7 +146,7 @@ def execute(self, context):
         :param context: The datastore to request from
         :returns: The initializes response message, exception message otherwise
         """
-        if not 1 <= self.count <= 0x7d0:
+        if not 1 <= self.count <= 0x7D0:
             return self.doException(merror.IllegalValue)
         if not context.validate(self.function_code, self.address, self.count):
             return self.doException(merror.IllegalAddress)
@@ -207,7 +207,7 @@ def execute(self, context):
         :param context: The datastore to request from
         :returns: The initializes response message, exception message otherwise
         """
-        if not 1 <= self.count <= 0x7d0:
+        if not 1 <= self.count <= 0x7D0:
             return self.doException(merror.IllegalValue)
         if not context.validate(self.function_code, self.address, self.count):
             return self.doException(merror.IllegalAddress)
@@ -243,6 +243,8 @@ def __init__(self, values=None, **kwargs):
 #  Exported symbols
 # ---------------------------------------------------------------------------#
 __all__ = [
-    "ReadCoilsRequest", "ReadCoilsResponse",
-    "ReadDiscreteInputsRequest", "ReadDiscreteInputsResponse",
+    "ReadCoilsRequest",
+    "ReadCoilsResponse",
+    "ReadDiscreteInputsRequest",
+    "ReadDiscreteInputsResponse",
 ]

pymodbus/bit_write_message.py

@@ -65,7 +65,7 @@ def decode(self, data):
         :param data: The packet data to decode
         """
         self.address, value = struct.unpack(">HH", data)
-        self.value = (value == ModbusStatus.On)
+        self.value = value == ModbusStatus.On
 
     def execute(self, context):
         """Run a write coil request against a datastore.
@@ -135,7 +135,7 @@ def decode(self, data):
         :param data: The packet data to decode
         """
         self.address, value = struct.unpack(">HH", data)
-        self.value = (value == ModbusStatus.On)
+        self.value = value == ModbusStatus.On
 
     def __str__(self):
         """Return a string representation of the instance.
@@ -202,7 +202,7 @@ def execute(self, context):
         :returns: The populated response or exception message
         """
         count = len(self.values)
-        if not 1 <= count <= 0x07b0:
+        if not 1 <= count <= 0x07B0:
             return self.doException(merror.IllegalValue)
         if self.byte_count != (count + 7) // 8:
             return self.doException(merror.IllegalValue)
@@ -218,7 +218,9 @@ def __str__(self):
         :returns: A string representation of the instance
         """
         params = (self.address, len(self.values))
-        return "WriteNCoilRequest (%d) => %d " % params  # pylint: disable=consider-using-f-string
+        return (
+            "WriteNCoilRequest (%d) => %d " % params  # pylint: disable=consider-using-f-string
+        )
 
     def get_response_pdu_size(self):  # pylint: disable=no-self-use
         """Get response pdu size.
@@ -274,6 +276,8 @@ def __str__(self):
 #  Exported symbols
 # ---------------------------------------------------------------------------#
 __all__ = [
-    "WriteSingleCoilRequest", "WriteSingleCoilResponse",
-    "WriteMultipleCoilsRequest", "WriteMultipleCoilsResponse",
+    "WriteSingleCoilRequest",
+    "WriteSingleCoilResponse",
+    "WriteMultipleCoilsRequest",
+    "WriteMultipleCoilsResponse",
 ]

pymodbus/client/asynchronous/__init__.py

@@ -37,5 +37,5 @@
 if installed := importlib.util.find_spec("twisted"):
     # Import deprecated async client only if twisted is installed #338
     from pymodbus.client.asynchronous.deprecated.asynchronous import *  # noqa: F401,F403
-    _logger.warning("Importing deprecated clients. "
-                    "Dependency Twisted is Installed")
+
+    _logger.warning("Importing deprecated clients. Dependency Twisted is Installed")