Add pylint: no-self-use and clean errors. (#858)

Author: janiversen

.pylintrc

@@ -82,6 +82,7 @@ enable=
     attribute-defined-outside-init,
     fixme,
     missing-docstring,
+    no-self-use,
     protected-access,
     too-few-public-methods,
     useless-suppression

examples/contrib/message_parser.py

@@ -96,7 +96,7 @@ def report(self, message): # pylint: disable=no-self-use
                 for k_item, v_item in v.items():
                     print("  %-12s => %s" % (k_item, v_item)) # pylint: disable=consider-using-f-string
 
-            elif isinstance(v, collections.Iterable):
+            elif isinstance(v, collections.Iterable): # pylint: disable=no-member
                 print("%-15s =" % k) # pylint: disable=consider-using-f-string
                 value = str([int(x) for x in v])
                 for line in textwrap.wrap(value, 60):

test/test_client_sync.py

@@ -314,7 +314,7 @@ def test_tcp_client_repr(self):
               f"ipaddr={client.host}, port={client.port}, timeout={client.timeout}>"
         self.assertEqual(repr(client), rep)
 
-    def test_tcp_client_register(self): # pylint: disable=no-self-use
+    def test_tcp_client_register(self):
         """ Test tcp client. """
         class CustomRequest: # pylint: disable=too-few-public-methods
             """ Dummy custom request. """
@@ -429,7 +429,7 @@ def test_tls_client_repr(self):
               f"timeout={client.timeout}>"
         self.assertEqual(repr(client), rep)
 
-    def test_tls_client_register(self): # pylint: disable=no-self-use
+    def test_tls_client_register(self):
         """ Test tls client. """
         class CustomeRequest: # pylint: disable=too-few-public-methods
             """ Dummy custom request. """
@@ -458,7 +458,7 @@ def test_sync_serial_client_instantiation(self):
         self.assertRaises(ParameterException,
                           lambda: ModbusSerialClient(method='something'))
 
-    def test_sync_serial_rtu_client_timeouts(self): # pylint: disable=no-self-use
+    def test_sync_serial_rtu_client_timeouts(self):
         """ Test sync serial rtu. """
         client = ModbusSerialClient(method="rtu", baudrate=9600)
         self.assertEqual(client.silent_interval, round((3.5 * 11 / 9600), 6))

test/test_server_context.py

@@ -51,7 +51,7 @@ def test_single_context_set(self):
         actual = self.context[0x00]
         self.assertEqual(slave, actual)
 
-    def test_single_context_register(self): # pylint: disable=no-self-use
+    def test_single_context_register(self):
         """ Test single context register. """
         request_db = [1, 2, 3]
         slave = ModbusSlaveContext()