Revert pep8 work, but keep fix #716, #804 and drop support for 3.7. (#866)

* Revert "Install isort (#864)"

This reverts commit 90c6b63.

* Revert "Solve logging.basicConfig. (#863)"

This reverts commit 9e377d2.

* Revert "Readd commented out imports. (#862)"

This reverts commit 3a05a5e.

* Revert "Active pylint invalid-name, and solve it. (#857)"

This reverts commit 5a79e96.

* Revert "Allow easy set of ModbusDeviceInformation. (#859)"

This reverts commit 0f265f9.

* Revert "Add pylint: no-self-use and clean errors. (#858)"

This reverts commit 88a85ea.

* Revert "Activate bandit in ci. (#855)"

This reverts commit f02c721.

* Revert "Please bandit, correct doc. (#856)"

This reverts commit 3ecdcee.

* Revert "Solve bandit security in test. (#854)"

This reverts commit 2837760.

* Revert "tests: use self.assert*() instead of assert. (#853)"

This reverts commit 0e52fe8.

* Revert "Solve bandit security problems in examples. (#852)"

This reverts commit 0dce597.

* Revert "Install bandit. (#851)"

This reverts commit 762903d.

* Revert "Active pylint missing-docstring. (#850)"

This reverts commit 5d44e2f.

* Revert "Add codespell to CI. (#848)"

This reverts commit 016d97a.

* Revert "Codespell for examples. (#849)"

This reverts commit 0017130.

* Revert "run codespell on pymodbus/pymodbus (#847)"

This reverts commit bee714b.

* Revert "Install codespell, and correct spell errors. (#846)"

This reverts commit f92156b.

* Revert "Remove useless pylint disable. (#845)"

This reverts commit 37fb268.

* Revert "Remove useless pylint disable in "test". (#844)"

This reverts commit 246b585.

* Revert "Remove useless pylint disable in "pymodbus". (#843)"

This reverts commit b7633b0.

* Revert "Remove useless pylint disable in "examples". (#842)"

This reverts commit 163025b.

* Revert "Reduce timeout to 15minutes (#841)"

This reverts commit 9c44c49.

* Revert "Add TODO for pylint. (#840)"

This reverts commit cfbe025.

* Revert "Activate pylint plugin: mccabe. (#839)"

This reverts commit 3c21596.

* Revert "Activate pylint plugin: code_style. (#838)"

This reverts commit 66e0535.

* Revert "Use assignment expr :=. (#837)"

This reverts commit 0b810d4.

* Revert "Use in-place tuple instead of array, where possible. (#836)"

This reverts commit 97dae2c.

* Revert "Activate pylint plugin: set_membership. (#835)"

This reverts commit f4557d2.

* Revert "Activate pylint plugin: docstyle. (#834)"

This reverts commit b409e2a.

* Revert "Prepare test for pylint docstyle. (#833)"

This reverts commit 85c8a4f.

* Revert "Prepare pymodbus for pylint docstyle. (#832)"

This reverts commit 9f268d2.

* Revert "Prepare pymodbus/server for pylint docstyle. (#831)"

This reverts commit 50029aa.

* Revert "Prepare pymodbus/repl for pylint docstyle. (#830)"

This reverts commit 6660942.

* Revert "Prepare pymodbus/framer for pylint docstyle. (#829)"

This reverts commit 0506645.

* Revert "Prepare pymodbus/datastore for pylint docstyle. (#828)"

This reverts commit 6c57403.

* Revert "Prepare pymodbus/client for pylint docstyle. (#827)"

This reverts commit fb6b669.

* Revert "Prepare examples/contrib for pylint docstyle. (#826)"

This reverts commit 098ca4d.

* Revert "Prepare examples/common for pylint docstyle. (#825)"

This reverts commit 62c1a8c.

* Revert "Prepare doc for pylint docstyle. (#824)"

This reverts commit d43a3d1.

* Revert "Activate pylint plugin: comparetozero. (#823)"

This reverts commit 756050e.

* Revert "Activate pylint plugin: typing,eq_without_hash,emptystring. (#822)"

This reverts commit a999bd6.

* Revert "Activate pylint plugin: pylint.extensions.comparison_placement (#821)"

This reverts commit 834c091.

* Revert "Activate pylint plugin: pylint.extensions.check_elif (#820)"

This reverts commit 8d40e8f.

* Revert "Solve pylint due to new pylintrc. (#819)"

This reverts commit 5427741.

* Revert "Fix #805. (#818)"

This reverts commit 2d5c701.

* Revert "Update pylint configuration. (#817)"

This reverts commit 0d51432.

* Revert "Add pylint to tox and ci. (#808)"

This reverts commit b6071e3.

* Revert "Drop support for python 3.7. (#806)"

This reverts commit 1f5a1f2.

* Revert "Fix #716 (#805)"

This reverts commit 3eab910.

* Revert "Remove compat.py. (#816)"

This reverts commit e722523.

* Revert "Remove compat: string_types, int2byte, byte2int. (#815)"

This reverts commit 5283a6b.

* Revert "Remove compat: iteritems,itervalues,iterkeys. (#814)"

This reverts commit 9447358.

* Revert "Remove compat socketserver, get_next, izip. (#813)"

This reverts commit c388c21.

* Revert "Remove six package. (#810)"

This reverts commit 2e08fd9.

* Revert "Jump timeout to 25 minutes, pypy3.7 fails too often on timeout. (#812)"

This reverts commit 087b6fe.

* Revert "Pylint 37. (#804)"

This reverts commit 59b092b.

* Revert "Pylint 36. (#803)"

This reverts commit e9dfb94.

* Revert "Pylint 35. (#802)"

This reverts commit e2dcd44.

* Revert "Pylint 34. (#801)"

This reverts commit 00fd76d.

* Revert "Pylint, duplicate lines suppressed. (#800)"

This reverts commit e8728e4.

* Revert "Pylint cleanup. (#799)"

This reverts commit bff778d.

* Revert "Pylint 31. (#798)"

This reverts commit 0f084f7.

* Revert "Pylint 30. (#794)"

This reverts commit 748c66f.

* Revert "Pylint 29. (#791)"

This reverts commit 0f08e62.

* Revert "Please SONAR (logging.basicConfig is a problem). (#797)"

This reverts commit c895f2b.

* Revert "Pylint 28. (#790) (#796)"

This reverts commit 1b0b2f4.

* Revert "Revert "Pylint 28. (#790)" (#795)"

This reverts commit 0a1f835.

* Revert "Pylint 28. (#790)"

This reverts commit 9210e21.

* Revert "Pylint batch 27 (#789) (#793)"

This reverts commit 3d5c56f.

* Revert "Revert "Pylint batch 27 (#789)" (#792)"

This reverts commit cec88cd.

* Revert "Pylint batch 27 (#789)"

This reverts commit 2e840c0.

* Revert "Pylint 26. (#788)"

This reverts commit 74827f3.

* Revert "Pylint 25. (#787)"

This reverts commit 25b990a.

* Revert "Pylint 24. (#786)"

This reverts commit e895a3d.

* Revert "Pylint 23. (#784)"

This reverts commit d48087b.

* Revert "Pylint 22. (#783)"

This reverts commit d57b28a.

* Revert "Pylint 21. (#782)"

This reverts commit 3f59c34.

* Revert "Pylint 20. (#781)"

This reverts commit ff62050.

* Revert "Pylint 19. (#780)"

This reverts commit 6a99bea.

* Revert "Pylint 18. (#779)"

This reverts commit 9b54407.

* Revert "Pylint 17. (#777)"

This reverts commit 0356967.

* Revert "Pylint 16. (#775)"

This reverts commit d69c0b9.

* Revert "Pylint 16. (#774)"

This reverts commit 41d2d76.

* Revert "Pylint batch 14 (#772)"

This reverts commit efccfef.

* Revert "Change class name(): -> class name:. (#773)"

This reverts commit f6766b7.

* Revert "Pylint 13. (#771)"

This reverts commit 5f2f827.

* Revert "Pylint 12. (#770)"

This reverts commit d063e9c.

* Revert "Pylint 11. (#769)"

This reverts commit d10e2a9.

* Revert "pylint 10. (#768)"

This reverts commit 4b9cf36.

* Revert "Pylint 9. (#767)"

This reverts commit c3b6252.

* Revert "Pylint 8. (#766)"

This reverts commit 91b04a1.

* Revert "Pylint 7. (#765)"

This reverts commit 467aefc.

* Revert "Pylint 6. (#762)"

This reverts commit 64a51ee.

* Revert "Pylint 5. (#764)"

This reverts commit e32dc16.

* Revert "Revert "Pylint 5. (#761)" (#763)"

This reverts commit 3e690a2.

* Revert "Pylint 5. (#761)"

This reverts commit f2dbb43.

* Revert "Pylint 4. (#760)"

This reverts commit acd0113.

* Revert "pylint 3. (#759)"

This reverts commit ab7c913.

* Revert "Pylint 2. (#757)"

This reverts commit 0a3e0bb.

* Revert "pylint batch 1 (#756)"

This reverts commit 0674442.

* Fix #716 (#805)

Change hardcode history file of REPL.
Change the the history file of the REPL from hardcoded `../.pymodhis` to hardcoded `.pymodhis`, so that REPL client will run from any working directory where the user has write permissions.

Place REPL history file to user directory in a cross platform way

* Drop support for python 3.7. (#806)

Python 3.7 has been marked "End Of Life", therefore we no longer
support it or test it.

* Fix #805. (#818)

Co-authored-by: Paul Grimes <[email protected]>

Author: janiversen

.github/workflows/ci.yml

@@ -20,8 +20,8 @@ jobs:
     name: ${{ matrix.task.name }} - ${{ matrix.os.name }} ${{ matrix.python.name }} ${{ matrix.arch.name }}
     runs-on: ${{ matrix.os.runs-on }}
     container: ${{ matrix.os.container[matrix.python.docker] }}
-    # present runtime seems to be about 2-4 minutes
-    # with pypy being the exception (7 minutes)
+    # present runtime seems to be about 2 minutes
+    # with pypy being the exception (10 minutes)
     timeout-minutes: 15
     strategy:
       fail-fast: false
@@ -179,15 +179,6 @@ jobs:
       fail-fast: false
       matrix:
         task:
-          - name: pylint
-            tox: pylint
-            # continue_on_error: true
-          - name: codespell
-            tox: codespell
-            # continue_on_error: true
-          - name: bandit
-            tox: bandit
-            # continue_on_error: true
           - name: flake8
             tox: flake8
             continue_on_error: true
@@ -267,6 +258,7 @@ jobs:
         run: |
           pip install --upgrade pip setuptools wheel
           pip install --upgrade tox
+          pip install --upgrade six
       - uses: twisted/[email protected]
       - name: Download Coverage
         if: matrix.task.download_coverage