Skip to content

Commit 9b57a83

Browse files
xxxxxliilpymumu
authored andcommitted
fix: allow set and default empty server name
中文翻译中明确说明 server name 设置为空时使用主机名,但是多年来 luci 页面并不允许其设置为空。 本提交使默认值变为占位符并允许默认值为空。 fix: 2173
1 parent 73f4930 commit 9b57a83

File tree

2 files changed

+4
-4
lines changed
  • package
    • luci-compat/files/luci/model/cbi/smartdns
    • luci/files/root/www/luci-static/resources/view/smartdns

2 files changed

+4
-4
lines changed

package/luci-compat/files/luci/model/cbi/smartdns/smartdns.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ o.rempty = false
4545

4646
---- server name
4747
o = s:taboption("settings", Value, "server_name", translate("Server Name"), translate("Smartdns server name"))
48-
o.default = "smartdns"
48+
o.placeholder = "server name"
4949
o.datatype = "hostname"
50-
o.rempty = false
50+
o.rempty = true
5151

5252
---- Port
5353
o = s:taboption("settings", Value, "port", translate("Local Port"),

package/luci/files/root/www/luci-static/resources/view/smartdns/smartdns.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,9 @@ return view.extend({
149149

150150
// server name;
151151
o = s.taboption("settings", form.Value, "server_name", _("Server Name"), _("Smartdns server name"));
152-
o.default = "smartdns";
152+
o.placeholder = "server name";
153153
o.datatype = "hostname";
154-
o.rempty = false;
154+
o.rempty = true;
155155

156156
// Port;
157157
o = s.taboption("settings", form.Value, "port", _("Local Port"),

0 commit comments

Comments
 (0)