src/ tests/: fix bug in insert_pdf(), #4412.

tests/: add reproducer test_4412().

src/utils.py: fix iteration in do_widgets().

Author: julian-smith-artifex-com

src/utils.py

@@ -1949,7 +1949,7 @@ def get_acroform(doc):
         parents[xref]["new_xref"] = parent_xref_new
         parents[xref]["new_kids"] = kids_xrefs_new
 
-    for i in src_range:
+    for i in range(len(src_range)):
         # read first copied over page in target
         tar_page = tar[start_at + i]
 

tests/resources/test_4412.pdf

@@ -298,3 +298,19 @@ def test_merge_checks2():
 
     assert len(set(names0 + names1)) == len(names2)
     assert kids2 == dup_kids
+
+
+test_4412_path = os.path.normpath(f'{__file__}/../../tests/resources/test_4412.pdf')
+
+def test_4412():
+    # This tests whether a page from a PDF containing widgets found in the wild
+    # can be inserted into a new document with default options (widget=True)
+    # and widget=False.
+    print()
+    for widget in True, False:
+        print(f'{widget=}', flush=1)
+        with pymupdf.open(test_4412_path) as doc, pymupdf.open() as new_doc:
+            buf = io.BytesIO()
+            new_doc.insert_pdf(doc, from_page=1, to_page=1)
+            new_doc.save(buf)
+            assert len(new_doc)==1