Error occured when drawing the Shape objects on mac m1 pro

[binodil]

Describe the bug (mandatory)

A clear and concise description of what the bug is.

To Reproduce (mandatory)

page = doc[0]
rot=page.rotation
page.set_rotation(0)
outpdf = fitz.open()
outpage = outpdf.new_page(width=page.rect.width, height=page.rect.height)
outpage.set_rotation(rot)
shape = outpage.new_shape()  # make a drawing canvas for the output page
# --------------------------------------
# loop through the paths and draw them
# --------------------------------------
for path in new_rects:
    # ------------------------------------
    # draw each entry of the 'items' list
    # ------------------------------------
    for item in path["items"]:  # these are the draw commands
        if item[0] == "l":  # line
            shape.draw_line(item[1], item[2])
        elif item[0] == "re":  # rectangle
            shape.draw_rect(item[1])
        elif item[0] == "qu":  # quad
            shape.draw_quad(item[1])
        elif item[0] == "c":  # curve
            shape.draw_bezier(item[1], item[2], item[3], item[4])
        else:
            raise ValueError("unhandled drawing", item)
    shape.finish(
            fill=path["fill"],  # fill color
            color=(1,0,0),  # line color
            dashes=path["dashes"],  # line dashing
            even_odd=path.get("even_odd", True),  # control color of overlaps
            closePath=path["closePath"],  # whether to connect last and first point
            lineJoin=path["lineJoin"],  # how line joins should look like
            lineCap=path["lineCap"],  # how line ends should look like
            width=path["width"],  # line width
            stroke_opacity=path.get("stroke_opacity", 1),  # same value for both
            fill_opacity=path.get("fill_opacity", 1),  # opacity parameters
            )
# all paths processed - commit the shape to its page
shape.commit()
outpdf.save(f"testdrawings.pdf")```

For problems when building or installing PyMuPDF, give the full output of the build/install command so that, for example, all pip/compiler/linker errors/warnings can be seen.

## The output: 
```---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
[/var/folders/s7/nr6v1nm5701691g1rwj5bbjw0000gn/T/ipykernel_7601/2766699606.py](https://file+.vscode-resource.vscode-cdn.net/var/folders/s7/nr6v1nm5701691g1rwj5bbjw0000gn/T/ipykernel_7601/2766699606.py) in ?()
     23 for path in new_rects:
     24     # ------------------------------------
     25     # draw each entry of the 'items' list
     26     # ------------------------------------
---> 27     for item in path["items"]:  # these are the draw commands
     28         if item[0] == "l":  # line
     29             shape.draw_line(item[1], item[2])
     30         elif item[0] == "re":  # rectangle

[~/Library/Python/3.9/lib/python/site-packages/fitz/utils.py](https://file+.vscode-resource.vscode-cdn.net/Users/sardor/Documents/Portfolio/Sequus/Meteor/grid_hunter/~/Library/Python/3.9/lib/python/site-packages/fitz/utils.py) in ?(self, width, color, fill, lineCap, lineJoin, dashes, even_odd, morph, closePath, fill_opacity, stroke_opacity, oc)

[~/Library/Python/3.9/lib/python/site-packages/fitz/fitz.py](https://file+.vscode-resource.vscode-cdn.net/Users/sardor/Documents/Portfolio/Sequus/Meteor/grid_hunter/~/Library/Python/3.9/lib/python/site-packages/fitz/fitz.py) in ?(self, gstate, CA, ca, blendmode)
   5925     def get_textpage(self, clip: rect_like = None, flags: int = 0, matrix=None) -> "TextPage":
   5926         CheckParent(self)
-> 5927         if matrix is None:
   5928             matrix = Matrix(1, 1)
   5929         old_rotation = self.rotation
   5930         if old_rotation != 0:

TypeError: '>=' not supported between instances of 'NoneType' and 'int'```

## Expected behavior (optional)
Describe what you expected to happen (if not obvious).

## Screenshots (optional)
If applicable, add screenshots to help explain your problem.


## Your configuration (mandatory)
 - Operating system, potentially version and bitness
 - Python version, bitness python3.9.6
 - PyMuPDF version, installation method (**wheel** or **generated** from source). 1.22.5 `PyMuPDF-1.22.5-cp39-cp39-macosx_11_0_arm64.whl (12.7 MB)`

For example, the output of `print(sys.version, "\n", sys.platform, "\n", fitz.__doc__)` would be sufficient (for the first two bullets).
```3.9.6 (default, May  7 2023, 23:32:44) 
[Clang 14.0.3 (clang-1403.0.22.14.1)] 
 darwin 
 
PyMuPDF 1.22.3: Python bindings for the MuPDF 1.22.0 library.
Version date: 2023-05-10 00:00:01.
Built for Python 3.9 on darwin (64-bit).

Additional context (optional)

Add any other context about the problem here.

[JorjMcKie]

This is not a bug:
If you have path types "f" ("fill") or "s" (stroke) then non-applicable dictionary keys will be set to None in the newer versions of PyMuPDF - as opposed to "inventing" default values for them.
For example, "fill_opacity" will be None if path["type"] == "s" - as opposed to 1.
Only for path["type"] == "fs" all dictionary keys will contain data.

[binodil]

Thanks for quick reply,
My path['type'] is 'f'. So how to make the code work?
How to change the type to the "fs"?

[ousia]

I would say that #2517 (reply in thread) also could be applied here.

[JorjMcKie]

My path['type'] is 'f'. So how to make the code work?

Adjust your code like this:

if path["fill"]: ...
if path["color"]: ...
etc.

For some background:
If a PDF path is a combination of "fill" and "stroke" commands, MuPDF will generate two separate paths: (1) a fill path, (2) a stroke path.
Both paths have identical items, but their other attributes are different with respect to the path type.
PyMuPDF detects this situation and joins both dictionaries to one with type = "fs" - for convenience.
This gives all paths the same set of keys.
But in contrast to earlier version, we no longer say path["fill_opacity"] = 1 if we in reality have a stroke path. This approach was what I called "false default values". Instead, now correctly path["fill"] = None is generated.