Skip to content

Commit 0a63d6d

Browse files
authored
cbuild_run: rename cbuild_run.telnet options to singular form
1 parent f44f0dc commit 0a63d6d

File tree

5 files changed

+39
-39
lines changed

5 files changed

+39
-39
lines changed

pyocd/core/options.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# pyOCD debugger
2-
# Copyright (c) 2018-2020,2025 Arm Limited
2+
# Copyright (c) 2018-2020,2025-2026 Arm Limited
33
# Copyright (c) 2020 Patrick Huesmann
44
# Copyright (c) 2022 Chris Reed
55
# SPDX-License-Identifier: Apache-2.0
@@ -205,15 +205,15 @@ class OptionInfo(NamedTuple):
205205
"Replace software breakpoints with hardware breakpoints."),
206206

207207
# Internal cbuild-run session options
208-
OptionInfo('cbuild_run.gdbserver_ports', tuple, None,
208+
OptionInfo('cbuild_run.gdbserver_port', tuple, None,
209209
"List of TCP ports for the gdbserver."),
210-
OptionInfo('cbuild_run.telnet_ports', tuple, None,
210+
OptionInfo('cbuild_run.telnet_port', tuple, None,
211211
"List of TCP ports for telnet server."),
212-
OptionInfo('cbuild_run.telnet_modes', tuple, None,
212+
OptionInfo('cbuild_run.telnet_mode', tuple, None,
213213
"List of telnet modes for each core."),
214-
OptionInfo('cbuild_run.telnet_files_in', tuple, None,
214+
OptionInfo('cbuild_run.telnet_file_in', tuple, None,
215215
"List of telnet input file paths for each core."),
216-
OptionInfo('cbuild_run.telnet_files_out', tuple, None,
216+
OptionInfo('cbuild_run.telnet_file_out', tuple, None,
217217
"List of telnet output file paths for each core."),
218218
]
219219

pyocd/core/session.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# pyOCD debugger
2-
# Copyright (c) 2018-2020,2025 Arm Limited
2+
# Copyright (c) 2018-2020,2025-2026 Arm Limited
33
# Copyright (c) 2021-2023 Chris Reed
44
# SPDX-License-Identifier: Apache-2.0
55
#
@@ -287,17 +287,17 @@ def _get_cbuild_run_config(self, command: Optional[str]) -> Dict[str, Any]:
287287

288288
# Only set gdbserver_port if it wasn't already set in options (command line).
289289
if not self.options.is_set('gdbserver_port'):
290-
debugger_options['cbuild_run.gdbserver_ports'] = self.cbuild_run.gdbserver_ports
290+
debugger_options['cbuild_run.gdbserver_port'] = self.cbuild_run.gdbserver_port
291291

292292
# Only set telnet_port if it wasn't already set in options (command line).
293293
if not self.options.is_set('telnet_port'):
294-
debugger_options['cbuild_run.telnet_ports'] = self.cbuild_run.telnet_ports
294+
debugger_options['cbuild_run.telnet_port'] = self.cbuild_run.telnet_port
295295

296296
if not self.options.is_set('semihost_console_type'):
297-
debugger_options['cbuild_run.telnet_modes'] = self.cbuild_run.telnet_modes
298-
telnet_files = self.cbuild_run.telnet_files
299-
debugger_options['cbuild_run.telnet_files_in'] = telnet_files.get('in')
300-
debugger_options['cbuild_run.telnet_files_out'] = telnet_files.get('out')
297+
debugger_options['cbuild_run.telnet_mode'] = self.cbuild_run.telnet_mode
298+
telnet_file = self.cbuild_run.telnet_file
299+
debugger_options['cbuild_run.telnet_file_in'] = telnet_file.get('in')
300+
debugger_options['cbuild_run.telnet_file_out'] = telnet_file.get('out')
301301

302302
# Set reset types for load operations.
303303
debugger_options['load.pre_reset'] = self.cbuild_run.pre_reset

pyocd/gdbserver/gdbserver.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# pyOCD debugger
2-
# Copyright (c) 2006-2020,2025 Arm Limited
2+
# Copyright (c) 2006-2020,2025-2026 Arm Limited
33
# Copyright (c) 2021-2022 Chris Reed
44
# Copyright (c) 2022 Clay McClure
55
# SPDX-License-Identifier: Apache-2.0
@@ -301,9 +301,9 @@ def __init__(self, session, core=None):
301301
self.target = self.board.target.cores[core]
302302
self.name = "gdb-server-core%d" % self.core
303303

304-
if session.options.is_set('cbuild_run.gdbserver_ports'):
304+
if session.options.is_set('cbuild_run.gdbserver_port'):
305305
# Per-core gdbserver ports configured.
306-
_port = session.options.get('cbuild_run.gdbserver_ports')[self.core]
306+
_port = session.options.get('cbuild_run.gdbserver_port')[self.core]
307307
# Check if no port was configured for this core, use 0 in that case.
308308
self.port = _port if _port is not None else 0
309309
else:

pyocd/target/pack/cbuild_run.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# pyOCD debugger
2-
# Copyright (c) 2025 Arm Limited
2+
# Copyright (c) 2025-2026 Arm Limited
33
# SPDX-License-Identifier: Apache-2.0
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -577,21 +577,21 @@ def connect_mode(self) -> str:
577577
return connect
578578

579579
@property
580-
def gdbserver_ports(self) -> Optional[Tuple]:
580+
def gdbserver_port(self) -> Optional[Tuple]:
581581
"""@brief GDB server port assignments from debugger section.
582582
The method will not be called frequently, so performance is not critical.
583583
"""
584-
return self._get_server_ports('gdbserver')
584+
return self._get_server_port('gdbserver')
585585

586586
@property
587-
def telnet_ports(self) -> Optional[Tuple]:
587+
def telnet_port(self) -> Optional[Tuple]:
588588
"""@brief Telnet server port assignments from debugger section.
589589
The method will not be called frequently, so performance is not critical.
590590
"""
591-
return self._get_server_ports('telnet')
591+
return self._get_server_port('telnet')
592592

593593
@property
594-
def telnet_modes(self) -> Tuple:
594+
def telnet_mode(self) -> Tuple:
595595
"""@brief Telnet server mode assignments from debugger section.
596596
The method will not be called frequently, so performance is not critical.
597597
"""
@@ -607,7 +607,7 @@ def telnet_modes(self) -> Tuple:
607607
global_mode = next((t.get('mode') for t in telnet_config if 'pname' not in t), 'off')
608608
global_mode = MODE_ALIASES.get(global_mode, global_mode)
609609
# Build list of telnet modes for each core
610-
telnet_modes = []
610+
telnet_mode = []
611611
for core in self.sorted_processors:
612612
mode = next((t.get('mode') for t in telnet_config if t.get('pname') == core.name), global_mode)
613613
mode = MODE_ALIASES.get(mode, mode)
@@ -616,20 +616,20 @@ def telnet_modes(self) -> Tuple:
616616
LOG.warning("Invalid telnet mode '%s' for core '%s' in cbuild-run, defaulting to '%s'",
617617
mode, core.name, global_mode)
618618
mode = global_mode
619-
telnet_modes.append(mode)
619+
telnet_mode.append(mode)
620620

621-
return tuple(telnet_modes)
621+
return tuple(telnet_mode)
622622

623623
@property
624-
def telnet_files(self) -> Dict[str, Optional[Tuple]]:
624+
def telnet_file(self) -> Dict[str, Optional[Tuple]]:
625625
"""@brief Telnet file path assignments from debugger section.
626626
The method will not be called frequently, so performance is not critical.
627627
"""
628628
# Get telnet configuration from debugger section
629629
telnet_config = self.debugger.get('telnet') or []
630-
telnet_modes = self.telnet_modes
630+
telnet_mode = self.telnet_mode
631631

632-
if not any(mode == 'file' for mode in telnet_modes):
632+
if not any(mode == 'file' for mode in telnet_mode):
633633
# No telnet file paths needed
634634
return {'in': None, 'out': None}
635635

@@ -651,7 +651,7 @@ def _resolve_path(file_path: Optional[str], strict: bool = False) -> Optional[st
651651

652652
if config_by_pname:
653653
# Build config per pname
654-
for proc_info, mode in zip(self.sorted_processors, telnet_modes):
654+
for proc_info, mode in zip(self.sorted_processors, telnet_mode):
655655
if mode != 'file':
656656
in_files.append(None)
657657
out_files.append(None)
@@ -672,7 +672,7 @@ def _resolve_path(file_path: Optional[str], strict: bool = False) -> Optional[st
672672
if config is not None:
673673
if len(self.sorted_processors) > 1:
674674
LOG.warning("Ignoring invalid telnet file configuration for multicore target in cbuild-run")
675-
for proc_info, mode in zip(self.sorted_processors, telnet_modes):
675+
for proc_info, mode in zip(self.sorted_processors, telnet_mode):
676676
if mode != 'file':
677677
in_files.append(None)
678678
out_files.append(None)
@@ -716,7 +716,7 @@ def populate_target(self, target: Optional[str] = None) -> None:
716716
})
717717
TARGET[target] = tgt
718718

719-
def _get_server_ports(self, server_type: str) -> Optional[Tuple]:
719+
def _get_server_port(self, server_type: str) -> Optional[Tuple]:
720720
"""@brief Generic method to get server port assignments from debugger section."""
721721
server_config = self.debugger.get(server_type, [])
722722
if not server_config:

pyocd/utility/stdio.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ class StdioTelnet(StdioBase):
5858
"""STDIO backend that uses a telnet server for reading from and writing to stdin/stdout."""
5959

6060
def __init__(self, session: Session, core: int = 0) -> None:
61-
if session.options.is_set('cbuild_run.telnet_ports'):
61+
if session.options.is_set('cbuild_run.telnet_port'):
6262
# Per-core telnet ports configured.
63-
telnet_port = session.options.get('cbuild_run.telnet_ports')[core]
63+
telnet_port = session.options.get('cbuild_run.telnet_port')[core]
6464
if telnet_port is None:
6565
LOG.info("Telnet port for core %d is not specified and will be auto-assigned", core)
6666
telnet_port = 0
@@ -119,15 +119,15 @@ class StdioFile(StdioBase):
119119

120120
def __init__(self, session: Session, core: int = 0) -> None:
121121
# Get file paths from session options
122-
if session.options.is_set('cbuild_run.telnet_files_out'):
123-
telnet_file_out = session.options.get('cbuild_run.telnet_files_out')[core]
122+
if session.options.is_set('cbuild_run.telnet_file_out'):
123+
telnet_file_out = session.options.get('cbuild_run.telnet_file_out')[core]
124124
if telnet_file_out is None:
125125
raise ValueError(f"STDIO file for core {core} requires a valid output file path")
126126
else:
127127
raise ValueError(f"STDIO file for core {core} requires a valid output file path")
128128

129-
if session.options.is_set('cbuild_run.telnet_files_in'):
130-
telnet_file_in = session.options.get('cbuild_run.telnet_files_in')[core]
129+
if session.options.is_set('cbuild_run.telnet_file_in'):
130+
telnet_file_in = session.options.get('cbuild_run.telnet_file_in')[core]
131131
else:
132132
telnet_file_in = None
133133

@@ -285,9 +285,9 @@ class StdioHandler(StdioBase):
285285

286286
def __init__(self, session: Session, core: int = 0, eot_enabled: bool = False) -> None:
287287

288-
if session.options.is_set('cbuild_run.telnet_modes'):
288+
if session.options.is_set('cbuild_run.telnet_mode'):
289289
# Per-core telnet modes configured.
290-
stdio_mode = session.options.get('cbuild_run.telnet_modes')[core]
290+
stdio_mode = session.options.get('cbuild_run.telnet_mode')[core]
291291
else:
292292
stdio_mode = session.options.get('semihost_console_type')
293293

0 commit comments

Comments
 (0)