diff --git a/CHANGELOG.md b/CHANGELOG.md index 13d710c8..f52607c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 (the ones that starts with `../` or `./`) [#174](https://github.com/pyodide/micropip/pull/174) +- Fixed an error when calling `micropip.install` with `deps=False` is set. + [#187](https://github.com/pyodide/micropip/pull/187) + ### Added - `micropip` now vendors `pypa/packaging` for better reliability. diff --git a/micropip/transaction.py b/micropip/transaction.py index f830f051..b3a82ad7 100644 --- a/micropip/transaction.py +++ b/micropip/transaction.py @@ -268,6 +268,8 @@ async def add_wheel( else: await wheel_download_task await self.gather_requirements(wheel.requires(extras)) + else: + await wheel_download_task self.wheels.append(wheel) diff --git a/tests/integration/test_integration.py b/tests/integration/test_integration.py index df5234b8..d50a8af8 100644 --- a/tests/integration/test_integration.py +++ b/tests/integration/test_integration.py @@ -33,6 +33,25 @@ async def _run(selenium): _run(selenium_standalone_micropip) +@integration_test_only +def test_integration_install_no_deps(selenium_standalone_micropip, pytestconfig): + @run_in_pyodide + async def _run(selenium): + import micropip + + await micropip.install("pyodide-micropip-test", deps=False) + + try: + # pyodide-micropip-test depends on snowballstemmer + import snowballstemmer # noqa: F401 + except ModuleNotFoundError: + pass + else: + raise Exception("Should raise!") + + _run(selenium_standalone_micropip) + + @integration_test_only def test_integration_list_basic(selenium_standalone_micropip, pytestconfig): @run_in_pyodide