|
| 1 | +"""Tests for install-emscripten CLI command""" |
| 2 | + |
| 3 | +import subprocess |
| 4 | +from pathlib import Path |
| 5 | + |
| 6 | +from typer.testing import CliRunner |
| 7 | + |
| 8 | +from pyodide_build.cli import xbuildenv |
| 9 | + |
| 10 | +runner = CliRunner() |
| 11 | + |
| 12 | + |
| 13 | +def test_install_emscripten_no_xbuildenv(tmp_path): |
| 14 | + """Test that install-emscripten fails when no xbuildenv exists""" |
| 15 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 16 | + |
| 17 | + result = runner.invoke( |
| 18 | + xbuildenv.app, |
| 19 | + [ |
| 20 | + "install-emscripten", |
| 21 | + "--path", |
| 22 | + str(envpath), |
| 23 | + ], |
| 24 | + ) |
| 25 | + |
| 26 | + assert result.exit_code != 0, result.stdout |
| 27 | + assert "Cross-build environment not found" in result.stdout, result.stdout |
| 28 | + |
| 29 | + |
| 30 | +def test_install_emscripten_default_version(tmp_path, monkeypatch): |
| 31 | + """Test installing Emscripten with default version""" |
| 32 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 33 | + envpath.mkdir() |
| 34 | + |
| 35 | + monkeypatch.setattr( |
| 36 | + "pyodide_build.cli.xbuildenv.get_build_flag", |
| 37 | + lambda name: "3.1.46", |
| 38 | + ) |
| 39 | + |
| 40 | + called = {} |
| 41 | + |
| 42 | + def fake_install(self, version): |
| 43 | + called["version"] = version |
| 44 | + return self.env_dir / "emsdk" |
| 45 | + |
| 46 | + monkeypatch.setattr( |
| 47 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 48 | + fake_install, |
| 49 | + ) |
| 50 | + |
| 51 | + result = runner.invoke( |
| 52 | + xbuildenv.app, |
| 53 | + [ |
| 54 | + "install-emscripten", |
| 55 | + "--path", |
| 56 | + str(envpath), |
| 57 | + ], |
| 58 | + ) |
| 59 | + |
| 60 | + assert result.exit_code == 0, result.stdout |
| 61 | + assert "Installing emsdk..." in result.stdout, result.stdout |
| 62 | + assert "Installing emsdk complete." in result.stdout, result.stdout |
| 63 | + assert "Use `source" in result.stdout, result.stdout |
| 64 | + assert "emsdk_env.sh` to set up the environment." in result.stdout, result.stdout |
| 65 | + assert called["version"] == "3.1.46" |
| 66 | + |
| 67 | + |
| 68 | +def test_install_emscripten_specific_version(tmp_path, monkeypatch): |
| 69 | + """Test installing Emscripten with a specific version""" |
| 70 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 71 | + envpath.mkdir() |
| 72 | + |
| 73 | + called = {} |
| 74 | + |
| 75 | + def fake_install(self, version): |
| 76 | + called["version"] = version |
| 77 | + return self.env_dir / "emsdk" |
| 78 | + |
| 79 | + monkeypatch.setattr( |
| 80 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 81 | + fake_install, |
| 82 | + ) |
| 83 | + |
| 84 | + emscripten_version = "3.1.46" |
| 85 | + result = runner.invoke( |
| 86 | + xbuildenv.app, |
| 87 | + [ |
| 88 | + "install-emscripten", |
| 89 | + "--version", |
| 90 | + emscripten_version, |
| 91 | + "--path", |
| 92 | + str(envpath), |
| 93 | + ], |
| 94 | + ) |
| 95 | + |
| 96 | + assert result.exit_code == 0, result.stdout |
| 97 | + assert "Installing emsdk..." in result.stdout, result.stdout |
| 98 | + assert "Installing emsdk complete." in result.stdout, result.stdout |
| 99 | + assert called["version"] == emscripten_version |
| 100 | + |
| 101 | + |
| 102 | +def test_install_emscripten_with_existing_emsdk(tmp_path, monkeypatch): |
| 103 | + """Test installing Emscripten when emsdk already exists (should pull updates)""" |
| 104 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 105 | + envpath.mkdir() |
| 106 | + |
| 107 | + existing_emsdk = envpath / "emsdk" |
| 108 | + existing_emsdk.mkdir() |
| 109 | + |
| 110 | + monkeypatch.setattr( |
| 111 | + "pyodide_build.cli.xbuildenv.get_build_flag", |
| 112 | + lambda name: "latest", |
| 113 | + ) |
| 114 | + |
| 115 | + def fake_install(self, version): |
| 116 | + assert version == "latest" |
| 117 | + assert existing_emsdk.exists() |
| 118 | + return existing_emsdk |
| 119 | + |
| 120 | + monkeypatch.setattr( |
| 121 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 122 | + fake_install, |
| 123 | + ) |
| 124 | + |
| 125 | + result = runner.invoke( |
| 126 | + xbuildenv.app, |
| 127 | + [ |
| 128 | + "install-emscripten", |
| 129 | + "--path", |
| 130 | + str(envpath), |
| 131 | + ], |
| 132 | + ) |
| 133 | + |
| 134 | + assert result.exit_code == 0, result.stdout |
| 135 | + assert "Installing emsdk..." in result.stdout, result.stdout |
| 136 | + assert "Installing emsdk complete." in result.stdout, result.stdout |
| 137 | + assert str(existing_emsdk / "emsdk_env.sh") in result.stdout |
| 138 | + |
| 139 | + |
| 140 | +def test_install_emscripten_git_failure(tmp_path, monkeypatch): |
| 141 | + """Test handling of git clone failure""" |
| 142 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 143 | + envpath.mkdir() |
| 144 | + |
| 145 | + monkeypatch.setattr( |
| 146 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 147 | + lambda self, version: (_ for _ in ()).throw( |
| 148 | + subprocess.CalledProcessError(1, "git clone") |
| 149 | + ), |
| 150 | + ) |
| 151 | + |
| 152 | + result = runner.invoke( |
| 153 | + xbuildenv.app, |
| 154 | + [ |
| 155 | + "install-emscripten", |
| 156 | + "--path", |
| 157 | + str(envpath), |
| 158 | + ], |
| 159 | + ) |
| 160 | + |
| 161 | + # Should fail due to git clone error |
| 162 | + assert result.exit_code != 0 |
| 163 | + assert isinstance(result.exception, subprocess.CalledProcessError) |
| 164 | + |
| 165 | + |
| 166 | +def test_install_emscripten_emsdk_install_failure(tmp_path, monkeypatch): |
| 167 | + """Test handling of emsdk install command failure""" |
| 168 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 169 | + envpath.mkdir() |
| 170 | + |
| 171 | + monkeypatch.setattr( |
| 172 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 173 | + lambda self, version: (_ for _ in ()).throw( |
| 174 | + subprocess.CalledProcessError(1, "./emsdk install") |
| 175 | + ), |
| 176 | + ) |
| 177 | + |
| 178 | + result = runner.invoke( |
| 179 | + xbuildenv.app, |
| 180 | + [ |
| 181 | + "install-emscripten", |
| 182 | + "--path", |
| 183 | + str(envpath), |
| 184 | + ], |
| 185 | + ) |
| 186 | + |
| 187 | + # Should fail due to emsdk install error |
| 188 | + assert result.exit_code != 0 |
| 189 | + assert isinstance(result.exception, subprocess.CalledProcessError) |
| 190 | + |
| 191 | + |
| 192 | +def test_install_emscripten_output_format(tmp_path, monkeypatch): |
| 193 | + """Test that the output message format is correct""" |
| 194 | + envpath = Path(tmp_path) / ".xbuildenv" |
| 195 | + envpath.mkdir() |
| 196 | + |
| 197 | + monkeypatch.setattr( |
| 198 | + "pyodide_build.cli.xbuildenv.get_build_flag", |
| 199 | + lambda name: "latest", |
| 200 | + ) |
| 201 | + |
| 202 | + expected_path = envpath / "emsdk" |
| 203 | + |
| 204 | + monkeypatch.setattr( |
| 205 | + "pyodide_build.xbuildenv.CrossBuildEnvManager.install_emscripten", |
| 206 | + lambda self, version: expected_path, |
| 207 | + ) |
| 208 | + |
| 209 | + result = runner.invoke( |
| 210 | + xbuildenv.app, |
| 211 | + [ |
| 212 | + "install-emscripten", |
| 213 | + "--path", |
| 214 | + str(envpath), |
| 215 | + ], |
| 216 | + ) |
| 217 | + |
| 218 | + assert result.exit_code == 0, result.stdout |
| 219 | + |
| 220 | + # Verify output format - check for key messages (logger adds extra lines) |
| 221 | + assert "Installing emsdk..." in result.stdout |
| 222 | + assert "Installing emsdk complete." in result.stdout |
| 223 | + assert "Use `source" in result.stdout |
| 224 | + assert "emsdk_env.sh` to set up the environment." in result.stdout |
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?v=4&size=40){kind=avatar}
0 commit comments