CI Enable node test [full build] (#170)

Author: ryanking13

.github/workflows/build.yml

@@ -314,6 +314,7 @@ jobs:
         test-config: [
           {runner: selenium, runtime: chrome, runtime-version: 134 },
           {runner: selenium, runtime: firefox, runtime-version: "136.0" },
+          {runner: selenium, runtime: node, runtime-version: "24" },
         ]
 
     steps:

packages/aiohttp/test_aiohttp.py

@@ -22,6 +22,7 @@ async def aiohttp_test_helper(selenium, patch, base_url, lock_data):
             assert body == expected
 
 
+@pytest.mark.xfail_browsers(node="Not available")
 def test_aiohttp(selenium):
     patch = (Path(__file__).parent / "aiohttp_patch.py").read_text()
     dist_dir = cast(str, pytest.pyodide_dist_dir)  # type:ignore[attr-defined]

packages/micropip/test_micropip.py

@@ -3,14 +3,15 @@
 from tempfile import TemporaryDirectory
 
 import pytest
-from pytest_pyodide import run_in_pyodide, spawn_web_server
-
-from conftest import package_is_built
+from pytest_pyodide import run_in_pyodide
 
 cpver = f"cp{sys.version_info.major}{sys.version_info.minor}"
 
 
 WHEEL_BASE = None
+SNOWBALL_WHEEL = (
+    Path(__file__).parent / "test" / "snowballstemmer-2.0.0-py2.py3-none-any.whl"
+)
 
 
 @pytest.fixture
@@ -43,9 +44,6 @@ def selenium_standalone_micropip(selenium_standalone):
     yield selenium_standalone
 
 
-SNOWBALL_WHEEL = "snowballstemmer-2.0.0-py2.py3-none-any.whl"
-
-
 def test_install_simple(selenium_standalone_micropip):
     selenium = selenium_standalone_micropip
     assert selenium.run_js(
@@ -65,38 +63,38 @@ def test_install_simple(selenium_standalone_micropip):
     ) == ["go", "go", "goe", "gone"]
 
 
-@pytest.mark.parametrize("base_url", ["'{base_url}'", "'.'"])
-def test_install_custom_url(selenium_standalone_micropip, base_url):
+def test_install_custom_url(selenium_standalone_micropip, httpserver):
     selenium = selenium_standalone_micropip
 
-    with spawn_web_server(Path(__file__).parent / "test") as server:
-        server_hostname, server_port, _ = server
-        base_url = f"http://{server_hostname}:{server_port}/"
-        url = base_url + SNOWBALL_WHEEL
+    httpserver.expect_oneshot_request(f"/{SNOWBALL_WHEEL.name}").respond_with_data(
+        SNOWBALL_WHEEL.read_bytes(),
+        content_type="application/zip",
+        headers={"Access-Control-Allow-Origin": "*"},
+        status=200,
+    )
+    url = httpserver.url_for(SNOWBALL_WHEEL.name)
 
-        selenium.run_js(
-            f"""
-            await pyodide.runPythonAsync(`
-                import micropip
-                await micropip.install('{url}')
-                import snowballstemmer
-            `);
-            """
-        )
+    selenium.run_js(
+        f"""
+        await pyodide.runPythonAsync(`
+            import micropip
+            await micropip.install('{url}')
+            import snowballstemmer
+        `);
+        """
+    )
 
 
 @pytest.mark.xfail_browsers(chrome="node only", firefox="node only")
 def test_install_file_protocol_node(selenium_standalone_micropip):
     selenium = selenium_standalone_micropip
-    from conftest import DIST_PATH
 
-    pyparsing_wheel_name = list(DIST_PATH.glob("pyparsing*.whl"))[0].name
     selenium.run_js(
         f"""
         await pyodide.runPythonAsync(`
             import micropip
-            await micropip.install('file:{pyparsing_wheel_name}')
-            import pyparsing
+            await micropip.install('file:{SNOWBALL_WHEEL.as_posix()}')
+            import snowballstemmer
         `);
         """
     )
@@ -146,114 +144,52 @@ def test_install_different_version2(selenium_standalone_micropip):
     )
 
 
-@pytest.mark.parametrize("jinja2", ["jinja2", "Jinja2"])
-def test_install_mixed_case2(selenium_standalone_micropip, jinja2):
-    selenium = selenium_standalone_micropip
-    selenium.run_js(
-        f"""
-        await pyodide.loadPackage("micropip");
-        await pyodide.runPythonAsync(`
-            import micropip
-            await micropip.install("{jinja2}")
-            import jinja2
-        `);
-        """
+def test_list_load_package_from_url(selenium_standalone_micropip, httpserver):
+    httpserver.expect_oneshot_request(f"/{SNOWBALL_WHEEL.name}").respond_with_data(
+        SNOWBALL_WHEEL.read_bytes(),
+        content_type="application/zip",
+        headers={"Access-Control-Allow-Origin": "*"},
+        status=200,
     )
+    url = httpserver.url_for(SNOWBALL_WHEEL.name)
 
-
-def test_list_load_package_from_url(selenium_standalone_micropip):
-    with spawn_web_server(Path(__file__).parent / "test") as server:
-        server_hostname, server_port, _ = server
-        base_url = f"http://{server_hostname}:{server_port}/"
-        url = base_url + SNOWBALL_WHEEL
-
-        selenium = selenium_standalone_micropip
-        selenium.run_js(
-            f"""
-            await pyodide.loadPackage({url!r});
-            await pyodide.runPythonAsync(`
-                import micropip
-                assert "snowballstemmer" in micropip.list()
-            `);
-            """
-        )
-
-
-def test_list_pyodide_package(selenium_standalone_micropip):
     selenium = selenium_standalone_micropip
     selenium.run_js(
-        """
-        await pyodide.runPythonAsync(`
-            import micropip
-            await micropip.install(
-                "regex"
-            );
-        `);
-        """
-    )
-    selenium.run_js(
-        """
+        f"""
+        await pyodide.loadPackage({url!r});
         await pyodide.runPythonAsync(`
             import micropip
-            pkgs = micropip.list()
-            assert "regex" in pkgs
-            assert pkgs["regex"].source.lower() == "pyodide"
+            assert "snowballstemmer" in micropip.list()
         `);
         """
     )
 
 
-def test_list_loaded_from_js(selenium_standalone_micropip):
-    selenium = selenium_standalone_micropip
-    selenium.run_js(
-        """
-        await pyodide.loadPackage("regex");
-        await pyodide.runPythonAsync(`
-            import micropip
-            pkgs = micropip.list()
-            assert "regex" in pkgs
-            assert pkgs["regex"].source.lower() == "pyodide"
-        `);
-        """
+def test_emfs(selenium_standalone_micropip, httpserver):
+    httpserver.expect_oneshot_request(f"/{SNOWBALL_WHEEL.name}").respond_with_data(
+        SNOWBALL_WHEEL.read_bytes(),
+        content_type="application/zip",
+        headers={"Access-Control-Allow-Origin": "*"},
+        status=200,
     )
+    url = httpserver.url_for(f"/{SNOWBALL_WHEEL.name}")
 
-
-def test_emfs(selenium_standalone_micropip):
-    with spawn_web_server(Path(__file__).parent / "test") as server:
-        server_hostname, server_port, _ = server
-        url = f"http://{server_hostname}:{server_port}/"
-
-        @run_in_pyodide(packages=["micropip"])
-        async def run_test(selenium, url, wheel_name):
-            import micropip
-            from pyodide.http import pyfetch
-
-            resp = await pyfetch(url + wheel_name)
-            await resp._into_file(open(wheel_name, "wb"))
-            await micropip.install("emfs:" + wheel_name)
-            import snowballstemmer
-
-            stemmer = snowballstemmer.stemmer("english")
-            assert stemmer.stemWords("go going goes gone".split()) == [
-                "go",
-                "go",
-                "goe",
-                "gone",
-            ]
-
-        run_test(selenium_standalone_micropip, url, SNOWBALL_WHEEL)
-
-
-def test_install_non_normalized_package(selenium_standalone_micropip):
-    if not package_is_built("ruamel-yaml"):
-        pytest.skip("ruamel.yaml not built")
-
-    selenium = selenium_standalone_micropip
-
-    selenium.run_async(
-        """
+    @run_in_pyodide(packages=["micropip"])
+    async def run_test(selenium, url, wheel_name):
         import micropip
-        await micropip.install("ruamel.yaml")
-        import ruamel.yaml
-        """
-    )
+        from pyodide.http import pyfetch
+
+        resp = await pyfetch(url)
+        await resp._into_file(open(wheel_name, "wb"))
+        await micropip.install("emfs:" + wheel_name)
+        import snowballstemmer
+
+        stemmer = snowballstemmer.stemmer("english")
+        assert stemmer.stemWords("go going goes gone".split()) == [
+            "go",
+            "go",
+            "goe",
+            "gone",
+        ]
+
+    run_test(selenium_standalone_micropip, url, SNOWBALL_WHEEL.name)

packages/python-flint/test_python_flint.py

@@ -14,15 +14,7 @@ def test_python_flint(selenium):
     assert a.gcd(a * b) == a
 
 
-@pytest.mark.xfail_browsers(firefox="times out", chrome="times out")
-@run_in_pyodide(packages=["python-flint"])
-def test_python_flint_tests(selenium):
-    from flint.test.__main__ import main
-
-    main("--tests", "--verbose")
-
-
-@pytest.mark.xfail_browsers(firefox="times out")
+@pytest.mark.xfail_browsers(firefox="times out", node="times out")
 @pytest.mark.parametrize(
     "module",
     [

packages/sisl/test_sisl.py

@@ -2,6 +2,7 @@
 from pytest_pyodide import run_in_pyodide
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_load_sisl(selenium):
@@ -11,6 +12,7 @@ def test_load_sisl(selenium):
     pass
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_nodes(selenium):
@@ -19,6 +21,7 @@ def test_nodes(selenium):
     pytest.main(["--pyargs", "sisl.nodes"])
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_geom(selenium):
@@ -27,6 +30,7 @@ def test_geom(selenium):
     pytest.main(["--pyargs", "sisl.geom"])
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_linalg(selenium):
@@ -35,6 +39,7 @@ def test_linalg(selenium):
     pytest.main(["--pyargs", "sisl.linalg"])
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_sparse(selenium):
@@ -43,6 +48,7 @@ def test_sparse(selenium):
     pytest.main(["--pyargs", "sisl.tests.test_sparse"])
 
 
+@pytest.mark.driver_timeout(60)
 @pytest.mark.xfail_browsers(firefox="Too slow")
 @run_in_pyodide(packages=["sisl-tests", "pytest"])
 def test_physics_sparse(selenium):