Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 10, 2024

Description

Related to:

As discussed in the two pull requests above, the fixes in SeleniumHQ/Selenium #14699 are causing numerous failures in our continuous integration tests. See ❌'s at https://github.com/pyodide/pyodide/pulls

While those fixes will be included in a future Selenium release, they are not yet on the Nightly build so let's pin selenium==4.25.0 to get our CI ✅ again.

@hoodmane says at #5149 (comment)

I'm okay with using the downgraded selenium for now. @ryanking13 you have any objection?

@ryanking13 says at #5149 (comment)

No objection.

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@cclauss cclauss changed the title requirements.txt: Pin selenium==4.25.0 to fix ci tests requirements.txt: Pin selenium==4.25.0 to fix ci failures Nov 10, 2024
@hoodmane hoodmane merged commit 993a8ee into pyodide:main Nov 10, 2024
40 checks passed
@cclauss cclauss deleted the selenium==4.25.0 branch November 10, 2024 11:44
@agriyakhetarpal
Copy link
Member

Thanks, @cclauss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants