Add test

Author: oraluben

src/auditwheel/tools.py

@@ -183,7 +183,20 @@ def __init__(
         self.env = env
         if self.env_default:
             if type:
-                self.env_default = type(self.env_default)
+                try:
+                    self.env_default = type(self.env_default)
+                except Exception:
+                    self.option_strings = kwargs["option_strings"]
+                    args = {
+                        "value": self.env_default,
+                        "type": type,
+                        "env": self.env,
+                    }
+                    msg = (
+                        "invalid type: %(value)r from environment variable "
+                        "%(env)r cannot be converted to %(type)r"
+                    )
+                    raise argparse.ArgumentError(self, msg % args) from None
             default = self.env_default
         if default:
             required = False

tests/unit/test_tools.py

@@ -3,6 +3,7 @@
 import argparse
 import lzma
 import zipfile
+import zlib
 from pathlib import Path
 
 import pytest
@@ -44,7 +45,7 @@ def test_environment_action(
     assert expected == args.PLAT
 
 
-def test_environment_action_invalid_env(monkeypatch: pytest.MonkeyPatch) -> None:
+def test_environment_action_invalid_plat_env(monkeypatch: pytest.MonkeyPatch) -> None:
     choices = ["linux", "manylinux1", "manylinux2010"]
     monkeypatch.setenv("AUDITWHEEL_PLAT", "foo")
     p = argparse.ArgumentParser()
@@ -59,6 +60,39 @@ def test_environment_action_invalid_env(monkeypatch: pytest.MonkeyPatch) -> None
         )
 
 
+def test_environment_action_invalid_zip_env(monkeypatch: pytest.MonkeyPatch) -> None:
+    choices = list(range(zlib.Z_NO_COMPRESSION, zlib.Z_BEST_COMPRESSION + 1))
+    monkeypatch.setenv("AUDITWHEEL_ZIP_LEVEL", "foo")
+    p = argparse.ArgumentParser()
+    with pytest.raises(argparse.ArgumentError):
+        p.add_argument(
+            "-z",
+            "--zip-level",
+            action=EnvironmentDefault,
+            metavar="zip",
+            env="AUDITWHEEL_ZIP_LEVEL",
+            dest="zip",
+            type=int,
+            help="Compress level to be used to create zip file.",
+            choices=choices,
+            default=zlib.Z_DEFAULT_COMPRESSION,
+        )
+    monkeypatch.setenv("AUDITWHEEL_ZIP_LEVEL", "10")
+    with pytest.raises(argparse.ArgumentError):
+        p.add_argument(
+            "-z",
+            "--zip-level",
+            action=EnvironmentDefault,
+            metavar="zip",
+            env="AUDITWHEEL_ZIP_LEVEL",
+            dest="zip",
+            type=int,
+            help="Compress level to be used to create zip file.",
+            choices=choices,
+            default=zlib.Z_DEFAULT_COMPRESSION,
+        )
+
+
 def _write_test_permissions_zip(path: Path) -> None:
     source_zip_xz = Path(__file__).parent / "test-permissions.zip.xz"
     with lzma.open(source_zip_xz) as f: