fix: clip zip timestamp to 1980-01-01 (#568)

zip timestamps do not use POSIX timestamp, they use DOS timestamps that starts   on 1980-01-01.

Author: mayeut

src/auditwheel/tools.py

@@ -142,6 +142,9 @@ def dir2zip(
         st = in_dir.stat()
         date_time = datetime.fromtimestamp(st.st_mtime, tz=timezone.utc)
     date_time_args = date_time.timetuple()[:6]
+    if date_time_args < (1980, 1, 1, 0, 0, 0):
+        logger.warning("dir2zip, clipping timestamp to 1980-01-01")
+        date_time_args = (1980, 1, 1, 0, 0, 0)
     compression = zipfile.ZIP_DEFLATED
     with zipfile.ZipFile(zip_fname, "w", compression=compression) as z:
         for dname, _, files in walk(in_dir):

tests/integration/test_bundled_wheels.py

@@ -3,7 +3,6 @@
 import importlib
 import os
 import platform
-import subprocess
 import sys
 import zipfile
 from argparse import Namespace
@@ -138,29 +137,25 @@ def test_analyze_wheel_abi_static_exe(caplog):
         assert result.overall_policy.name == "manylinux_2_5_x86_64"
 
 
-@pytest.mark.skipif(platform.machine() != "x86_64", reason="only checked on x86_64")
-def test_wheel_source_date_epoch(tmp_path, monkeypatch):
-    wheel_build_path = tmp_path / "wheel"
-    subprocess.run(
-        [
-            sys.executable,
-            "-m",
-            "pip",
-            "wheel",
-            "--no-deps",
-            "-w",
-            wheel_build_path,
-            HERE / "sample_extension",
-        ],
-        check=True,
+@pytest.mark.parametrize(
+    "timestamp",
+    [
+        (0, 315532800),  # zip timestamp starts 1980-01-01, not 1970-01-01
+        (315532799, 315532800),  # zip timestamp starts 1980-01-01, not 1970-01-01
+        (315532801, 315532800),  # zip timestamp round odd seconds down to even seconds
+        (315532802, 315532802),
+        (650203201, 650203200),  # zip timestamp round odd seconds down to even seconds
+    ],
+)
+def test_wheel_source_date_epoch(timestamp, tmp_path, monkeypatch):
+    wheel_path = (
+        HERE / "arch-wheels/musllinux_1_2/testsimple-0.0.1-cp312-cp312-linux_x86_64.whl"
     )
-
-    wheel_path, *_ = list(wheel_build_path.glob("*.whl"))
     wheel_output_path = tmp_path / "out"
     args = Namespace(
         LIB_SDIR=".libs",
         ONLY_PLAT=False,
-        PLAT="manylinux_2_5_x86_64",
+        PLAT="auto",
         STRIP=False,
         UPDATE_TAGS=True,
         WHEEL_DIR=wheel_output_path,
@@ -173,7 +168,8 @@ def test_wheel_source_date_epoch(tmp_path, monkeypatch):
         prog="auditwheel",
         verbose=1,
     )
-    monkeypatch.setenv("SOURCE_DATE_EPOCH", "650203200")
+
+    monkeypatch.setenv("SOURCE_DATE_EPOCH", str(timestamp[0]))
     # patchelf might not be available as we aren't running in a manylinux container
     # here. We don't need need it in this test, so just patch it.
     with mock.patch("auditwheel.patcher._verify_patchelf"):
@@ -182,6 +178,5 @@ def test_wheel_source_date_epoch(tmp_path, monkeypatch):
     output_wheel, *_ = list(wheel_output_path.glob("*.whl"))
     with zipfile.ZipFile(output_wheel) as wheel_file:
         for file in wheel_file.infolist():
-            assert (
-                datetime(*file.date_time, tzinfo=timezone.utc).timestamp() == 650203200
-            )
+            file_date_time = datetime(*file.date_time, tzinfo=timezone.utc)
+            assert file_date_time.timestamp() == timestamp[1]