Skip to content

feat: support uv with Android #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: support uv with Android #2587

wants to merge 10 commits into from
+69 −25

Conversation

henryiii
Copy link
Contributor

Now supported in the latest uv release.

@henryiii henryiii force-pushed the henryiii/feat/uvandroid branch 3 times, most recently from a400b8e to 18c45a5 Compare September 11, 2025 05:07
@henryiii henryiii marked this pull request as ready for review September 11, 2025 22:11
@henryiii henryiii requested a review from mhsmith as a code owner September 11, 2025 22:11
@henryiii
Copy link
Contributor Author

@mhsmith, does this seem reasonable? I'll be in India for a week, so feel free to edit as needed.

@mhsmith
Copy link
Member

mhsmith commented Sep 17, 2025 •
edited
Loading

Looks good so far. A few comments:

  • The docs say build[uv] will use uv "when making all build and test environments", but the current version of this PR still uses pip to install the test environment. This may be a problem if pip is not installed at all.

    To test this, the "frontend_good" test should probably be extended to include a test command.

  • The Android references in the build-frontend docs should be updated. Suggest the following:

    uv currently does not support Windows on ARM,
    musllinux on s390x, AndroidPyodide, or iOS. Legacy dependencies like
    setuptools on Python < 3.12 and pip are not installed if using uv.

    On Android and Pyodide, only "build" isthe "pip" frontend is not supported.

@henryiii henryiii force-pushed the henryiii/feat/uvandroid branch from 18c45a5 to 7b4079b Compare September 24, 2025 14:46
@henryiii
Copy link
Contributor Author

henryiii commented Sep 24, 2025 •
edited by mhsmith
Loading

Looks like we need to translate pip's --platform into --python-platform on uv?

error: invalid value 'android_21_x86_64' for '--python-platform <PYTHON_PLATFORM>'
[possible values: windows, linux, macos, x86_64-pc-windows-msvc, aarch64-pc-windows-msvc, i686-pc-windows-msvc, x86_64-unknown-linux-gnu, aarch64-apple-darwin, x86_64-apple-darwin, aarch64-unknown-linux-gnu, aarch64-unknown-linux-musl, x86_64-unknown-linux-musl, riscv64-unknown-linux, x86_64-manylinux2014, x86_64-manylinux_2_17, x86_64-manylinux_2_28, x86_64-manylinux_2_31, x86_64-manylinux_2_32, x86_64-manylinux_2_33, x86_64-manylinux_2_34, x86_64-manylinux_2_35, x86_64-manylinux_2_36, x86_64-manylinux_2_37, x86_64-manylinux_2_38, x86_64-manylinux_2_39, x86_64-manylinux_2_40, aarch64-manylinux2014, aarch64-manylinux_2_17, aarch64-manylinux_2_28, aarch64-manylinux_2_31, aarch64-manylinux_2_32, aarch64-manylinux_2_33, aarch64-manylinux_2_34, aarch64-manylinux_2_35, aarch64-manylinux_2_36, aarch64-manylinux_2_37, aarch64-manylinux_2_38, aarch64-manylinux_2_39, aarch64-manylinux_2_40, aarch64-linux-android, x86_64-linux-android, wasm32-pyodide2024, arm64-apple-ios, arm64-apple-ios-simulator, x86_64-apple-ios-simulator]

@henryiii
feat: support uv with Android
4b023db 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
tests: rework skips to show uv vs. build
5ca7157 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
tests: rework skips to show uv vs. build (again)
bb20a8e 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Revert "tests: rework skips to show uv vs. build (again)"
b05351d 
This reverts commit dbf3385.
@henryiii
tests: make skips aware of markers
f83b500 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
fix: use uv in test environment too
48ca3d7 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
docs: touch up description for build-frontend
a14e192 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
fix: python-platfrom on uv
1f1db32 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
fix: python-platfrom on uv is different
a0350fa 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/feat/uvandroid branch from ee40809 to a0350fa Compare October 8, 2025 18:16
henryiii
henryiii commented Oct 8, 2025
View reviewed changes
mhsmith
mhsmith reviewed Oct 9, 2025
View reviewed changes
test/test_android.py
wheels = cibuildwheel_run(
tmp_path,
add_env={**cp313_env, "CIBW_BUILD_FRONTEND": "build"},
add_env={**cp313_env, **build_frontend_env, "CIBW_TEST_COMMAND": "python -m site"},
Copy link
Member

@mhsmith mhsmith Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests with a test command need to be decorated with @needs_emulator, so they'll be skipped on the CI platforms that don't support that.

But maybe this test doesn't need a test command at all. OK, I guess it does need one in order to check the test environment installed by uv. But this command doesn't actually use the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsmith mhsmith mhsmith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @mhsmith