Skip to content

Commit 704d1a5

Browse files
Apply suggestions from code review
Co-authored-by: Jelle Zijlstra <[email protected]>
1 parent 94743f9 commit 704d1a5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

source/discussions/downstream-packaging.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ distribution, and then uses it to build a wheel. This ensures that the source
121121
distribution actually works, and that it won't accidentally install fewer files
122122
than the official wheels.
123123

124-
Ideally, use the source distribution also run tests, build documentation,
124+
Ideally, also use the source distribution to run tests, build documentation,
125125
and so on, or add specific tests to make sure that all necessary files were
126126
actually included. Understandably, this requires more effort, so it's fine
127127
not do that — downstream packagers will report any missing files promptly.
@@ -271,7 +271,7 @@ message rather than fall back to a vendored version. This gives the packager
271271
the opportunity to notice their mistake and a chance to consciously decide
272272
how to solve it.
273273

274-
Note that it is reasonable for upstream projects to leave *testing* of building with
274+
It is reasonable for upstream projects to leave *testing* of building with
275275
system dependencies to their downstream repackagers. The goal of these guidelines
276276
is to facilitate more effective collaboration between upstream projects and downstream
277277
repackagers, not to suggest upstream projects take on tasks that downstream repackagers

0 commit comments

Comments
 (0)